2011-11-30 22:02:08

by Curt Wohlgemuth

Subject: [PATCH] ext4: Remove unused local variable

In get_implied_cluster_alloc(), rr_cluster_end was being
defined and set, but was never used. Removed this.

Signed-off-by: Curt Wohlgemuth <[email protected]>
---
fs/ext4/extents.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 61fa9e1..fc5a673 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3626,7 +3626,7 @@ static int get_implied_cluster_alloc(struct super_block *sb,
struct ext4_sb_info *sbi = EXT4_SB(sb);
ext4_lblk_t c_offset = map->m_lblk & (sbi->s_cluster_ratio-1);
ext4_lblk_t ex_cluster_start, ex_cluster_end;
- ext4_lblk_t rr_cluster_start, rr_cluster_end;
+ ext4_lblk_t rr_cluster_start;
ext4_lblk_t ee_block = le32_to_cpu(ex->ee_block);
ext4_fsblk_t ee_start = ext4_ext_pblock(ex);
unsigned short ee_len = ext4_ext_get_actual_len(ex);
@@ -3637,7 +3637,6 @@ static int get_implied_cluster_alloc(struct super_block *sb,

/* The requested region passed into ext4_map_blocks() */
rr_cluster_start = EXT4_B2C(sbi, map->m_lblk);
- rr_cluster_end = EXT4_B2C(sbi, map->m_lblk + map->m_len - 1);

if ((rr_cluster_start == ex_cluster_end) ||
(rr_cluster_start == ex_cluster_start)) {
--
1.7.3.1

2011-12-18 22:40:42

by Theodore Ts'o

Subject: Re: [PATCH] ext4: Remove unused local variable

On Wed, Nov 30, 2011 at 02:02:04PM -0800, Curt Wohlgemuth wrote:
> In get_implied_cluster_alloc(), rr_cluster_end was being
> defined and set, but was never used. Removed this.
>
> Signed-off-by: Curt Wohlgemuth <[email protected]>

Applied, thanks.

- Ted