2012-04-22 15:50:52

by Eldad Zack

Subject: [PATCH] [EXT4] super.c: unused variable warning without CONFIG_QUOTA

sb info is only checked with quota support.

fs/ext4/super.c: In function ‘parse_options’:
fs/ext4/super.c:1600:23: warning: unused variable ‘sbi’ [-Wunused-variable]

Signed-off-by: Eldad Zack <[email protected]>
---
fs/ext4/super.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 6da1935..e1fb1d5 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1597,7 +1597,9 @@ static int parse_options(char *options, struct super_block *sb,
unsigned int *journal_ioprio,
int is_remount)
{
+#ifdef CONFIG_QUOTA
struct ext4_sb_info *sbi = EXT4_SB(sb);
+#endif
char *p;
substring_t args[MAX_OPT_ARGS];
int token;
--
1.7.10

2012-04-24 01:39:59

by Theodore Ts'o

Subject: Re: [PATCH] [EXT4] super.c: unused variable warning without CONFIG_QUOTA

On Sun, Apr 22, 2012 at 05:50:52PM +0200, Eldad Zack wrote:
> sb info is only checked with quota support.
>
> fs/ext4/super.c: In function ‘parse_options’:
> fs/ext4/super.c:1600:23: warning: unused variable ‘sbi’ [-Wunused-variable]
>
> Signed-off-by: Eldad Zack <[email protected]>

Thanks, applied.

- Ted