2012-06-04 03:18:30

by Tao Ma

Subject: [PATCH] ext4: Don't set i_flags in EXT4_IOC_SETFLAGS.

From: Tao Ma <[email protected]>

7990696 uses the ext4_{set,clear}_inode_flags() functions to change
the i_flags automatically but fails to remove the error setting of
i_flags. So we still have the problem of trashing state flags. So
remove it.

Cc: "Theodore Ts'o" <[email protected]>
Signed-off-by: Tao Ma <[email protected]>
---
fs/ext4/ioctl.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 8ad112a..e34deac 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -123,7 +123,6 @@ long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
else
ext4_clear_inode_flag(inode, i);
}
- ei->i_flags = flags;

ext4_set_inode_flags(inode);
inode->i_ctime = ext4_current_time(inode);
--
1.7.4.1

2012-06-07 23:05:55

by Theodore Ts'o

Subject: Re: [PATCH] ext4: Don't set i_flags in EXT4_IOC_SETFLAGS.

On Mon, Jun 04, 2012 at 11:18:18AM +0800, Tao Ma wrote:
> From: Tao Ma <[email protected]>
>
> 7990696 uses the ext4_{set,clear}_inode_flags() functions to change
> the i_flags automatically but fails to remove the error setting of
> i_flags. So we still have the problem of trashing state flags. So
> remove it.
>
> Cc: "Theodore Ts'o" <[email protected]>
> Signed-off-by: Tao Ma <[email protected]>

Good catch! Sorry that I missed it. I've taken this patch, thanks.

- Ted