2012-06-19 15:36:00

by Haibo

Subject: [PATCH] change a comment on fs/ext4/extents.c

From: HaiboLiu <[email protected]>

May be it's better.

Signed-off-by: HaiboLiu <[email protected]>
---
fs/ext4/extents.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 74f23c2..db671b9 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1807,11 +1807,10 @@ has_space:
nearex->ee_len = newext->ee_len;

merge:
- /* try to merge extents to the right */
+ /* try to merge extents */
if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
ext4_ext_try_to_merge(inode, path, nearex);

- /* try to merge extents to the left */

/* time to correct all indexes above */
err = ext4_ext_correct_indexes(handle, inode, path);
--
1.7.9.5

2012-06-20 15:43:25

by Zheng Liu

Subject: Re: [PATCH] change a comment on fs/ext4/extents.c

Hi Haibo,

If your patch only relates to ext4, please change the patch's subject
like this:
[PATCH] ext4: change a comment on fs/ext4/extents.c

On Tue, Jun 19, 2012 at 11:35:47PM +0800, [email protected] wrote:
> From: HaiboLiu <[email protected]>
>
> May be it's better.

Maybe the following commit log is better:
In this patch (197217a5), ext4_ext_try_to_merge has been changed to
merge an extent both left and right. So we need to update the comment
in here.

Regards,
Zheng

>
> Signed-off-by: HaiboLiu <[email protected]>
> ---
> fs/ext4/extents.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 74f23c2..db671b9 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -1807,11 +1807,10 @@ has_space:
> nearex->ee_len = newext->ee_len;
>
> merge:
> - /* try to merge extents to the right */
> + /* try to merge extents */
> if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
> ext4_ext_try_to_merge(inode, path, nearex);
>
> - /* try to merge extents to the left */
>
> /* time to correct all indexes above */
> err = ext4_ext_correct_indexes(handle, inode, path);
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2012-06-21 18:14:47

by Haibo

Subject: Re:[PATCH] change a comment on fs/ext4/extents.c

> Hi Haibo,
>
> If your patch only relates to ext4, please change the patch's subject
> like this:
> [PATCH] ext4: change a comment on fs/ext4/extents.c
>
> On Tue, Jun 19, 2012 at 11:35:47PM +0800, [email protected] wrote:
> > From: HaiboLiu <[email protected]>
> >
> > May be it's better.
>
> Maybe the following commit log is better:
> In this patch (197217a5), ext4_ext_try_to_merge has been changed to
> merge an extent both left and right. So we need to update the comment
> in here.
>
> Regards,
> Zheng
>
> >
> > Signed-off-by: HaiboLiu <[email protected]>
> > ---
> > fs/ext4/extents.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> > index 74f23c2..db671b9 100644
> > --- a/fs/ext4/extents.c
> > +++ b/fs/ext4/extents.c
> > @@ -1807,11 +1807,10 @@ has_space:
> > nearex->ee_len = newext->ee_len;
> >
> > merge:
> > - /* try to merge extents to the right */
> > + /* try to merge extents */
> > if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
> > ext4_ext_try_to_merge(inode, path, nearex);
> >
> > - /* try to merge extents to the left */
> >
> > /* time to correct all indexes above */
> > err = ext4_ext_correct_indexes(handle, inode, path);
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

Thanks for your suggestion. I update the patch subject and the patch comment and resend it.

Regards,
Haibo Liu