2012-06-21 18:31:15

by Haibo

Subject: [PATCH][v2] ext4: delete a no useful sentence

From: Haibo Liu <[email protected]>

In this patch, the sentence "poff = block % blocks_per_page"
in ext4_mb_get_buddy_page_lock has no effect.
So we should delete it to save cpu.

v1->v2: update the patch subject and the patch comment.

Signed-off-by: Haibo Liu <[email protected]>
---
fs/ext4/mballoc.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index cb990b2..7223bd4 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1016,7 +1016,6 @@ static int ext4_mb_get_buddy_page_lock(struct super_block *sb,

block++;
pnum = block / blocks_per_page;
- poff = block % blocks_per_page;
page = find_or_create_page(inode->i_mapping, pnum, GFP_NOFS);
if (!page)
return -EIO;
--
1.7.9.5

2012-07-09 14:25:31

by Theodore Ts'o

Subject: Re: [v2] ext4: delete a no useful sentence

On Thu, Jun 21, 2012 at 08:31:06AM -0000, Liu Haibo wrote:
> From: Haibo Liu <[email protected]>
>
> In this patch, the sentence "poff = block % blocks_per_page"
> in ext4_mb_get_buddy_page_lock has no effect.
> So we should delete it to save cpu.
>
> v1->v2: update the patch subject and the patch comment.
>
> Signed-off-by: Haibo Liu <[email protected]>

Applied, thanks. BTW, I modified the patch description a little to
note that the compiler would optimize out the statement, but it's
better to remove unused C statements.

- Ted