2012-09-04 08:14:58

by Sachin Kamat

Subject: [PATCH] ext3: Replace 0 with NULL for pointer in super.c file

Fixes the following sparse warning:
fs/ext3/super.c:983:45: warning: Using plain integer as NULL pointer

Signed-off-by: Sachin Kamat <[email protected]>
---
fs/ext3/super.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index cf1fb17..0e17142 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -980,7 +980,7 @@ static int parse_options (char *options, struct super_block *sb,
* Initialize args struct so we know whether arg was
* found; some options take optional arguments.
*/
- args[0].to = args[0].from = 0;
+ args[0].to = args[0].from = NULL;
token = match_token(p, tokens, args);
switch (token) {
case Opt_bsd_df:
--
1.7.4.1

2012-09-04 10:00:25

by Jan Kara

Subject: Re: [PATCH] ext3: Replace 0 with NULL for pointer in super.c file

On Tue 04-09-12 13:42:00, Sachin Kamat wrote:
> Fixes the following sparse warning:
> fs/ext3/super.c:983:45: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Sachin Kamat <[email protected]>
Thanks. I've added the patch to my tree.

Honza

> ---
> fs/ext3/super.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index cf1fb17..0e17142 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -980,7 +980,7 @@ static int parse_options (char *options, struct super_block *sb,
> * Initialize args struct so we know whether arg was
> * found; some options take optional arguments.
> */
> - args[0].to = args[0].from = 0;
> + args[0].to = args[0].from = NULL;
> token = match_token(p, tokens, args);
> switch (token) {
> case Opt_bsd_df:
> --
> 1.7.4.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR