2013-05-24 04:33:06

by Theodore Ts'o

Subject: [PATCH] add generic/286 to the auto and quick groups

The generic/286 test tests SEEK_HOLE and SEEK_DATA, and is reasonably
fast. We should just run the test by default.

Signed-off-by: "Theodore Ts'o" <[email protected]>
---
tests/generic/group | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/group b/tests/generic/group
index e2ef70e..bd443c1 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -103,7 +103,7 @@
277 auto ioctl quick metadata
280 auto quota freeze dangerous
285 auto rw
-286 other
+286 auto quick other
288 auto quick ioctl trim
294 auto quick
299 auto aio enospc rw stress
--
1.7.12.rc0.22.gcdd159b

2013-05-24 04:54:24

by Eric Sandeen

Subject: Re: [PATCH] add generic/286 to the auto and quick groups

On 5/23/13 11:33 PM, Theodore Ts'o wrote:
> The generic/286 test tests SEEK_HOLE and SEEK_DATA, and is reasonably
> fast. We should just run the test by default.
>
> Signed-off-by: "Theodore Ts'o" <[email protected]>

Seems fine to me

Reviewed-by: Eric Sandeen <[email protected]>

another patch to follow to fix it on kernels that don't support it.

> ---
> tests/generic/group | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/group b/tests/generic/group
> index e2ef70e..bd443c1 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -103,7 +103,7 @@
> 277 auto ioctl quick metadata
> 280 auto quota freeze dangerous
> 285 auto rw
> -286 other
> +286 auto quick other
> 288 auto quick ioctl trim
> 294 auto quick
> 299 auto aio enospc rw stress
>

2013-05-28 16:05:43

by Rich Johnston

Subject: Re: [PATCH] add generic/286 to the auto and quick groups

On 05/23/2013 11:33 PM, Theodore Ts'o wrote:
> The generic/286 test tests SEEK_HOLE and SEEK_DATA, and is reasonably
> fast. We should just run the test by default.
>
> Signed-off-by: "Theodore Ts'o" <[email protected]>
> ---
> tests/generic/group | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/group b/tests/generic/group
> index e2ef70e..bd443c1 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -103,7 +103,7 @@
> 277 auto ioctl quick metadata
> 280 auto quota freeze dangerous
> 285 auto rw
> -286 other
> +286 auto quick other
> 288 auto quick ioctl trim
> 294 auto quick
> 299 auto aio enospc rw stress
>
Thanks, this patch has been committed:

commit f45c6881577221e04f6cfe19d25e571bee088996
Author: Theodore Ts'o <[email protected]>
Date: Tue May 28 11:01:01 2013 -0500

xfstests: add generic/286 to the auto and quick groups

--Rich

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs