2015-05-15 21:01:13

by Fabian Frédérick

Subject: [PATCH 1/1 linux-next] ext4: fix incorrect type argument

Fix sparse warning introduced in commit
9bd8212f981e
("ext4 crypto: add encryption policy and password salt support")

fs/ext4/ioctl.c:678:35: warning: incorrect type in argument 1
(different address spaces)
fs/ext4/ioctl.c:678:35: expected void [noderef] <asn:1>*to
fs/ext4/ioctl.c:678:35: got void *<noident>

Signed-off-by: Fabian Frederick <[email protected]>
---
fs/ext4/ioctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 2cb9e17..3c5e530 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -675,8 +675,8 @@ encryption_policy_out:
if (err)
return err;
}
- if (copy_to_user((void *) arg, sbi->s_es->s_encrypt_pw_salt,
- 16))
+ if (copy_to_user((void __user *) arg,
+ sbi->s_es->s_encrypt_pw_salt, 16))
return -EFAULT;
return 0;
}
--
2.4.0

2015-06-08 16:21:57

by Theodore Ts'o

Subject: Re: [PATCH 1/1 linux-next] ext4: fix incorrect type argument

On Fri, May 15, 2015 at 11:01:13PM +0200, Fabian Frederick wrote:
> Fix sparse warning introduced in commit
> 9bd8212f981e
> ("ext4 crypto: add encryption policy and password salt support")
>
> fs/ext4/ioctl.c:678:35: warning: incorrect type in argument 1
> (different address spaces)
> fs/ext4/ioctl.c:678:35: expected void [noderef] <asn:1>*to
> fs/ext4/ioctl.c:678:35: got void *<noident>
>
> Signed-off-by: Fabian Frederick <[email protected]>

Thanks for pointing this out! I'll fix this and another sparse
warning at the same time.

- Ted