2017-08-03 01:21:23

by Daeho Jeong

Subject: [PATCH] ext4: release discard bio after sending discard commands

We've changed the discard command handling into parallel manner.
But, in this change, I forgot decreasing the usage count of the bio
which was used to send discard request. I'm sorry about that.

Signed-off-by: Daeho Jeong <[email protected]>
Reviewed-by: Jan Kara <[email protected]>
Fixes: a015434480dc ("ext4: send parallel discards on commit
completions")
---
fs/ext4/mballoc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index ab70b69e644c..88317b0cf7b8 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2892,8 +2892,10 @@ void ext4_process_freed_data(struct super_block *sb, tid_t commit_tid)
break;
}

- if (discard_bio)
+ if (discard_bio) {
submit_bio_wait(discard_bio);
+ bio_put(discard_bio);
+ }
}

list_for_each_entry_safe(entry, tmp, &freed_data_list, efd_list)
--
2.13.0

2017-08-05 17:13:59

by Theodore Ts'o

Subject: Re: [PATCH] ext4: release discard bio after sending discard commands

On Thu, Aug 03, 2017 at 10:21:36AM +0900, Daeho Jeong wrote:
> We've changed the discard command handling into parallel manner.
> But, in this change, I forgot decreasing the usage count of the bio
> which was used to send discard request. I'm sorry about that.
>
> Signed-off-by: Daeho Jeong <[email protected]>
> Reviewed-by: Jan Kara <[email protected]>
> Fixes: a015434480dc ("ext4: send parallel discards on commit
> completions")

Thanks, applied.

- Ted