2009-11-24 02:15:59

by Justin Maggard

[permalink] [raw]
Subject: System hang with EXT4

Hi all,

I've recently run into an issue with ext4 and delayed allocation where
my system will silently hang just seconds into a dbench run. I first
saw this using 2.6.30.9, but it still happens with 2.6.32-rc8. I've
tried with an SMP x86_64 system, and a UP i386 system. The SMP x86_64
system hangs every time for me within 15 seconds, but the UP i386
system never hangs on me. If I remount with -o nodelalloc on the SMP
system, the hang goes away. There are no messages printed out by the
kernel; it just locks hard. Has anyone seen this before? I'm just
running "dbench 500" to produce this behavior.

-Justin


2009-12-08 15:18:10

by Jan Kara

[permalink] [raw]
Subject: Re: System hang with EXT4

Hi,

> I've recently run into an issue with ext4 and delayed allocation where
> my system will silently hang just seconds into a dbench run. I first
> saw this using 2.6.30.9, but it still happens with 2.6.32-rc8. I've
> tried with an SMP x86_64 system, and a UP i386 system. The SMP x86_64
> system hangs every time for me within 15 seconds, but the UP i386
> system never hangs on me. If I remount with -o nodelalloc on the SMP
> system, the hang goes away. There are no messages printed out by the
> kernel; it just locks hard. Has anyone seen this before? I'm just
> running "dbench 500" to produce this behavior.
Can you still switch consoles after the system hangs (it's good to
debug this on a text console)? If yes, could you press Alt-Sysrq-w and
take a picture of the console by digital camera or so (take pictures of
as many screens as possible using console scrollback)? Thanks.

Honza
--
Jan Kara <[email protected]>
SuSE CR Labs

2009-12-10 23:43:00

by Justin Maggard

[permalink] [raw]
Subject: Re: System hang with EXT4

On Wed, Dec 9, 2009 at 5:23 PM, Justin Maggard <[email protected]> wrote:
> On Tue, Dec 8, 2009 at 7:18 AM, Jan Kara <[email protected]> wrote:
>> ?Can you still switch consoles after the system hangs (it's good to
>> debug this on a text console)? If yes, could you press Alt-Sysrq-w and
>> take a picture of the console by digital camera or so (take pictures of
>> as many screens as possible using console scrollback)? Thanks.
>
> Thanks for the response. ?Console scrollback doesn't seem to work for
> me in that mode. ?I tried it three times. ?Two of the times the list
> was empty. ?The other time, the screen just listed a bunch of rm
> processes.

I have a little more information to add. ?After noticing the recent
"Fix potential quota deadlock" patch on the mailing list, I figured it
would be worth a shot to try it without quotas enabled. ?This also
avoids the system hang. ?I tried applying that patch, but still had
the same symptoms using that kernel. ?So I'm seeing a consistent
system hang with ext4 when delalloc and quotas are enabled on an SMP
system. ?With either quotas or delalloc disabled, it doesn't hang.
Both enabled on a single processor system also doesn't hang.

-Justin

2009-12-11 01:29:36

by Dmitry Monakhov

[permalink] [raw]
Subject: Re: System hang with EXT4

Justin Maggard <[email protected]> writes:

> On Wed, Dec 9, 2009 at 5:23 PM, Justin Maggard <[email protected]> wrote:
>> On Tue, Dec 8, 2009 at 7:18 AM, Jan Kara <[email protected]> wrote:
>>>  Can you still switch consoles after the system hangs (it's good to
>>> debug this on a text console)? If yes, could you press Alt-Sysrq-w and
>>> take a picture of the console by digital camera or so (take pictures of
>>> as many screens as possible using console scrollback)? Thanks.
>>
>> Thanks for the response.  Console scrollback doesn't seem to work for
>> me in that mode.  I tried it three times.  Two of the times the list
>> was empty.  The other time, the screen just listed a bunch of rm
>> processes.
>
> I have a little more information to add.  After noticing the recent
> "Fix potential quota deadlock" patch on the mailing list, I figured it
> would be worth a shot to try it without quotas enabled.  This also
> avoids the system hang.  I tried applying that patch, but still had
> the same symptoms using that kernel.  So I'm seeing a consistent
> system hang with ext4 when delalloc and quotas are enabled on an SMP
> system.  With either quotas or delalloc disabled, it doesn't hang.
> Both enabled on a single processor system also doesn't hang.
You also may try another patch
"[PATCH] ext4: fix sleep inside spinlock issue aka #14739 V2"
>
> -Justin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2009-12-11 02:17:04

by Justin Maggard

[permalink] [raw]
Subject: Re: System hang with EXT4

On Thu, Dec 10, 2009 at 5:29 PM, Dmitry Monakhov <[email protected]> wrote:
> Justin Maggard <[email protected]> writes:
>> I have a little more information to add. ?After noticing the recent
>> "Fix potential quota deadlock" patch on the mailing list, I figured it
>> would be worth a shot to try it without quotas enabled. ?This also
>> avoids the system hang. ?I tried applying that patch, but still had
>> the same symptoms using that kernel. ?So I'm seeing a consistent
>> system hang with ext4 when delalloc and quotas are enabled on an SMP
>> system. ?With either quotas or delalloc disabled, it doesn't hang.
>> Both enabled on a single processor system also doesn't hang.
> You also may try another patch
> "[PATCH] ext4: fix sleep inside spinlock issue aka #14739 V2"

Yes, that patch looks like it did the trick. Thanks!

2009-12-11 02:37:03

by Dmitry Monakhov

[permalink] [raw]
Subject: Re: System hang with EXT4

Justin Maggard <[email protected]> writes:

> On Thu, Dec 10, 2009 at 5:29 PM, Dmitry Monakhov <[email protected]> wrote:
>> Justin Maggard <[email protected]> writes:
>>> I have a little more information to add.  After noticing the recent
>>> "Fix potential quota deadlock" patch on the mailing list, I figured it
>>> would be worth a shot to try it without quotas enabled.  This also
>>> avoids the system hang.  I tried applying that patch, but still had
>>> the same symptoms using that kernel.  So I'm seeing a consistent
>>> system hang with ext4 when delalloc and quotas are enabled on an SMP
>>> system.  With either quotas or delalloc disabled, it doesn't hang.
>>> Both enabled on a single processor system also doesn't hang.
>> You also may try another patch
>> "[PATCH] ext4: fix sleep inside spinlock issue aka #14739 V2"
>
> Yes, that patch looks like it did the trick. Thanks!
Ohhh.. in fact i've to apologies my patch is wrong a little bit
after i_block_reservation_lock was reacquired second time
i_reserved_meta_blocks block's may be changed so we have to
use add instead of assign

- EXT4_I(inode)->i_reserved_meta_blocks = mdblocks;
+ EXT4_I(inode)->i_reserved_meta_blocks += md_needed;
As result quota leak is possible on heavy SMP stress test.
I've already send correct version.