2017-12-15 02:32:33

by Zhouyi Zhou

Subject: [PATCH] FS: EXT4: syn error in __ext4_grp_locked_error

From: Zhouyi Zhou <[email protected]>

In function __ext4_grp_locked_error, __save_error_info
is called to save error info in super block block, but does not sync
that information to disk to info the subsequence fsck after reboot.

This patch sync the error information to disk. After this patch,
I think there is no obvious EXT4 error handle branche which leads to
"Remounting filesystem read-only" will leave the disk partition miss
the subsequence fsck.

Compiled in x86_64 Linux
Signed-off-by: Zhouyi Zhou <[email protected]>
---
fs/ext4/super.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 7c46693..7159438 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -742,6 +742,7 @@ __acquires(bitlock)
}

ext4_unlock_group(sb, grp);
+ ext4_commit_super(sb, 1);
ext4_handle_error(sb);
/*
* We only get here in the ERRORS_RO case; relocking the group
--
2.1.4

2018-01-11 18:13:07

by Theodore Ts'o

Subject: Re: [PATCH] FS: EXT4: syn error in __ext4_grp_locked_error

On Fri, Dec 15, 2017 at 02:32:16AM +0000, [email protected] wrote:
> From: Zhouyi Zhou <[email protected]>
>
> In function __ext4_grp_locked_error, __save_error_info
> is called to save error info in super block block, but does not sync
> that information to disk to info the subsequence fsck after reboot.
>
> This patch sync the error information to disk. After this patch,
> I think there is no obvious EXT4 error handle branche which leads to
> "Remounting filesystem read-only" will leave the disk partition miss
> the subsequence fsck.
>
> Compiled in x86_64 Linux
> Signed-off-by: Zhouyi Zhou <[email protected]>

Applied, thanks.

- Ted