2022-05-04 14:04:50

by Byungchul Park

[permalink] [raw]
Subject: [PATCH RFC v6 18/21] dept: Disable Dept on struct crypto_larval's completion for now

struct crypto_larval's completion is used for multiple purposes e.g.
waiting for test to complete or waiting for probe to complete.

The completion variable needs to be split according to what it's used
for. Otherwise, Dept cannot distinguish one from another and doesn't
work properly. Now that it isn't, disable Dept on it.

Signed-off-by: Byungchul Park <[email protected]>
---
crypto/api.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/crypto/api.c b/crypto/api.c
index 69508ae..305d24c 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -115,7 +115,12 @@ struct crypto_larval *crypto_larval_alloc(const char *name, u32 type, u32 mask)
larval->alg.cra_destroy = crypto_larval_destroy;

strlcpy(larval->alg.cra_name, name, CRYPTO_MAX_ALG_NAME);
- init_completion(&larval->completion);
+ /*
+ * TODO: Split ->completion according to what it's used for e.g.
+ * ->test_completion, ->probe_completion and the like, so that
+ * Dept can track its dependency properly.
+ */
+ init_completion_nocheck(&larval->completion);

return larval;
}
--
1.9.1