2024-02-24 13:49:49

by Chengming Zhou

Subject: [PATCH] ext4: remove SLAB_MEM_SPREAD flag usage

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
its usage so we can delete it from slab. No functional change.

Signed-off-by: Chengming Zhou <[email protected]>
---
fs/ext4/super.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index eb689fb85ce9..9a744f22aa24 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1500,8 +1500,7 @@ static int __init init_inodecache(void)
{
ext4_inode_cachep = kmem_cache_create_usercopy("ext4_inode_cache",
sizeof(struct ext4_inode_info), 0,
- (SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD|
- SLAB_ACCOUNT),
+ SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT,
offsetof(struct ext4_inode_info, i_data),
sizeof_field(struct ext4_inode_info, i_data),
init_once);
--
2.40.1

2024-02-26 04:22:32

by Chengming Zhou

Subject: Re: [PATCH] ext4: remove SLAB_MEM_SPREAD flag usage

On 2024/2/24 21:48, [email protected] wrote:
> From: Chengming Zhou <[email protected]>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete to avoid confusion for users.
Here we can just remove all its users, which has no functional change.

[1] https://lore.kernel.org/all/[email protected]/

Thanks!

>
> Signed-off-by: Chengming Zhou <[email protected]>
> ---
> fs/ext4/super.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index eb689fb85ce9..9a744f22aa24 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1500,8 +1500,7 @@ static int __init init_inodecache(void)
> {
> ext4_inode_cachep = kmem_cache_create_usercopy("ext4_inode_cache",
> sizeof(struct ext4_inode_info), 0,
> - (SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD|
> - SLAB_ACCOUNT),
> + SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT,
> offsetof(struct ext4_inode_info, i_data),
> sizeof_field(struct ext4_inode_info, i_data),
> init_once);

2024-03-14 03:55:52

by Theodore Ts'o

Subject: Re: [PATCH] ext4: remove SLAB_MEM_SPREAD flag usage

On Sat, 24 Feb 2024 13:48:22 +0000, [email protected] wrote:
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
>
>

Applied, thanks!

[1/1] ext4: remove SLAB_MEM_SPREAD flag usage
commit: 708623737b0a28aff33bff0237862a2e08bc5c97

Best regards,
--
Theodore Ts'o <[email protected]>