2022-11-08 00:53:33

by Lu, Davina

[permalink] [raw]
Subject: configurable lazytime for EXT4, is name ok?

Hi Ted,

Sorry to bother you with a quick question: I am doing a patch for configurable lazytime for EXT4, Before submit the patch I would like to double check the names first. I added a "lazytime_flush=xxx" in mount show options, not sure if this is ok to continue.

As far as I know, lazytime is an option for EXT4 and other file systems. My patch make ext4 can be supported as before: without any parameters E.g. mount -o lazytime,...
Or can be supported with parameters (in ms) E.g. mount -o lazytime=30, ...

So when we show the options by mount -t ext4, if no parameter configured, the result shows as before:
/dev/nvme1n1 on /rdsdbdata1 type ext4 (rw,noatime,nodiratime,lazytime,data=ordered)

If has parameters configured, the result shows as below, added one "lazytime_flush=xxx". Not sure if this sound ok for you?
/dev/nvme1n1 on /rdsdbdata1 type ext4 (rw,noatime,nodiratime,lazytime,lazytime_flush=100ms,data=ordered)

I tested "ext4/053"of latest xfstest-dev with my patch and it can pass the result(I changed a bit 053 since I am running on 5.10, removed one mount option" no_prefetch_block_bitmaps" that 5.10 doesn't support).

Thanks
Davina