2023-07-26 07:50:36

by Muchun Song

[permalink] [raw]
Subject: Re: [PATCH v2 29/47] vmw_balloon: dynamically allocate the vmw-balloon shrinker



> On Jul 24, 2023, at 17:43, Qi Zheng <[email protected]> wrote:
>
> In preparation for implementing lockless slab shrink, use new APIs to
> dynamically allocate the vmw-balloon shrinker, so that it can be freed
> asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU
> read-side critical section when releasing the struct vmballoon.
>
> And we can simply exit vmballoon_init() when registering the shrinker
> fails. So the shrinker_registered indication is redundant, just remove it.
>
> Signed-off-by: Qi Zheng <[email protected]>

Nice cleanup.

Reviewed-by: Muchun Song <[email protected]>