Hi Mingming,
With respect to ext4-patch-queue it is kind of difficult to find who wrote the patch.
I guess we can solve this by adding From: < author name > in the patches. This will make sure
when the patches get applied to linus tree we have the right author.
with the below diff to noextent_mount option patch i get the below history when applying the patches
using stgit via stgit --import --series
diff --git a/ext4_noextent_mount_opt.patch b/ext4_noextent_mount_opt.patch
index c349afb..e9a8d6f 100644
--- a/ext4_noextent_mount_opt.patch
+++ b/ext4_noextent_mount_opt.patch
@@ -1,3 +1,4 @@
+From: Mingming Cao <[email protected]>
Add a mount option to turn off extents.
Signed-off-by: Mingming Cao <[email protected]>
$ git log
commit f89bcb4ca03dde8b12d3c722483aae84c3d2072d
Author: Mingming Cao <[email protected]>
Date: Wed Jul 4 10:32:19 2007 +0530
Add a mount option to turn off extents.
Signed-off-by: Mingming Cao <[email protected]>
Without the change: I get below
commit 4a4f228f99e263767fe5b395cdb843a5c5d083fe
Author: Aneesh Kumar K.V <[email protected]>
Date: Wed Jul 4 10:05:19 2007 +0530
Turn on extents feature by default in ext4 filesystem. User could use
-o noextents to turn it off.
Signed-off-by: Mingming Cao <[email protected]>
-aneesh
On Wed, 2007-07-04 at 10:37 +0530, Aneesh Kumar K.V wrote:
> Hi Mingming,
>
> With respect to ext4-patch-queue it is kind of difficult to find who wrote the patch.
> I guess we can solve this by adding From: < author name > in the patches. This will make sure
> when the patches get applied to linus tree we have the right author.
>
Thanks, Aneesh, I will add From: <authro> for all patches in ext4 patch
queue.
Mingming
> with the below diff to noextent_mount option patch i get the below history when applying the patches
> using stgit via stgit --import --series
>
>
> diff --git a/ext4_noextent_mount_opt.patch b/ext4_noextent_mount_opt.patch
> index c349afb..e9a8d6f 100644
> --- a/ext4_noextent_mount_opt.patch
> +++ b/ext4_noextent_mount_opt.patch
> @@ -1,3 +1,4 @@
> +From: Mingming Cao <[email protected]>
> Add a mount option to turn off extents.
>
> Signed-off-by: Mingming Cao <[email protected]>
>
> $ git log
> commit f89bcb4ca03dde8b12d3c722483aae84c3d2072d
> Author: Mingming Cao <[email protected]>
> Date: Wed Jul 4 10:32:19 2007 +0530
>
> Add a mount option to turn off extents.
>
> Signed-off-by: Mingming Cao <[email protected]>
>
> Without the change: I get below
>
> commit 4a4f228f99e263767fe5b395cdb843a5c5d083fe
> Author: Aneesh Kumar K.V <[email protected]>
> Date: Wed Jul 4 10:05:19 2007 +0530
>
> Turn on extents feature by default in ext4 filesystem. User could use
> -o noextents to turn it off.
>
> Signed-off-by: Mingming Cao <[email protected]>
>
>
> -aneesh
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
On Jul 03, 2007 23:27 -0400, Mingming Cao wrote:
> On Wed, 2007-07-04 at 10:37 +0530, Aneesh Kumar K.V wrote:
> > With respect to ext4-patch-queue it is kind of difficult to find who wrote the patch.
> > I guess we can solve this by adding From: < author name > in the patches. This will make sure
> > when the patches get applied to linus tree we have the right author.
> >
>
> Thanks, Aneesh, I will add From: <authro> for all patches in ext4 patch
> queue.
You may as well add "Signed-off-by: <author>", since that is the standard
way to do this. If you have any questions about who wrote a particular
CFS patch I can tell you.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
On Wed, 2007-07-04 at 22:54 -0600, Andreas Dilger wrote:
> On Jul 03, 2007 23:27 -0400, Mingming Cao wrote:
> > On Wed, 2007-07-04 at 10:37 +0530, Aneesh Kumar K.V wrote:
> > > With respect to ext4-patch-queue it is kind of difficult to find who wrote the patch.
> > > I guess we can solve this by adding From: < author name > in the patches. This will make sure
> > > when the patches get applied to linus tree we have the right author.
> > >
> >
> > Thanks, Aneesh, I will add From: <authro> for all patches in ext4 patch
> > queue.
>
> You may as well add "Signed-off-by: <author>", since that is the standard
> way to do this. If you have any questions about who wrote a particular
> CFS patch I can tell you.
You should never add someone else's Signed-off-by without being
explicitly asked to do so.
Shaggy
--
David Kleikamp
IBM Linux Technology Center
On Wed, Jul 04, 2007 at 10:54:16PM -0600, Andreas Dilger wrote:
> On Jul 03, 2007 23:27 -0400, Mingming Cao wrote:
> > On Wed, 2007-07-04 at 10:37 +0530, Aneesh Kumar K.V wrote:
> > > With respect to ext4-patch-queue it is kind of difficult to find who wrote the patch.
> > > I guess we can solve this by adding From: < author name > in the patches. This will make sure
> > > when the patches get applied to linus tree we have the right author.
> > >
> >
> > Thanks, Aneesh, I will add From: <authro> for all patches in ext4 patch
> > queue.
>
> You may as well add "Signed-off-by: <author>", since that is the standard
> way to do this. If you have any questions about who wrote a particular
> CFS patch I can tell you.
In general the first Signed-off-by: is the author, yes. I believe
what Aneesh is talking about is formatting the patches so that when
they are pulled into git, "git log" shows the correct author information.
- Ted