2008-10-16 07:26:18

by Eric Sesterhenn

Subject: [PATCH] ext4 missing newlines

hi,

there are some newlines missing in ext4_check_descriptors, which
cause the printk level to be printed out when the next printk call
is made:

[ 778.847265] EXT4-fs: ext4_check_descriptors: Block bitmap for group 0
not in group (block 1509949442)!<3>EXT4-fs: group descriptors corrupted!
[ 802.646630] EXT4-fs: ext4_check_descriptors: Inode bitmap for group 0
not in group (block 9043971)!<3>EXT4-fs: group descriptors corrupted!

Signed-off-by: Eric Sesterhenn <[email protected]>

--- linux/fs/ext4/super.c.orig 2008-10-16 09:19:19.000000000 +0200
+++ linux/fs/ext4/super.c 2008-10-16 09:19:50.000000000 +0200
@@ -1618,14 +1618,14 @@ static int ext4_check_descriptors(struct
if (block_bitmap < first_block || block_bitmap > last_block) {
printk(KERN_ERR "EXT4-fs: ext4_check_descriptors: "
"Block bitmap for group %lu not in group "
- "(block %llu)!", i, block_bitmap);
+ "(block %llu)!\n", i, block_bitmap);
return 0;
}
inode_bitmap = ext4_inode_bitmap(sb, gdp);
if (inode_bitmap < first_block || inode_bitmap > last_block) {
printk(KERN_ERR "EXT4-fs: ext4_check_descriptors: "
"Inode bitmap for group %lu not in group "
- "(block %llu)!", i, inode_bitmap);
+ "(block %llu)!\n", i, inode_bitmap);
return 0;
}
inode_table = ext4_inode_table(sb, gdp);
@@ -1633,7 +1633,7 @@ static int ext4_check_descriptors(struct
inode_table + sbi->s_itb_per_group - 1 > last_block) {
printk(KERN_ERR "EXT4-fs: ext4_check_descriptors: "
"Inode table for group %lu not in group "
- "(block %llu)!", i, inode_table);
+ "(block %llu)!\n", i, inode_table);
return 0;
}
spin_lock(sb_bgl_lock(sbi, i));

2008-10-16 14:48:57

by Theodore Ts'o

Subject: Re: [PATCH] ext4 missing newlines

On Thu, Oct 16, 2008 at 09:26:14AM +0200, Eric Sesterhenn wrote:
>
> there are some newlines missing in ext4_check_descriptors, which
> cause the printk level to be printed out when the next printk call
> is made:

Thanks for the patch; I've added it to the ext4 patch queue.

- Ted