2009-04-13 23:05:00

by Chuck Ebbert

Subject: [patch] ext4: really print the find_group_flex fallback warning only once

ext4: really print the find_group_flex fallback warning only once

Missing braces caused the warning to print more than once.

Signed-Off-By: Chuck Ebbert <[email protected]>

--- linux-2.6.27.noarch.orig/fs/ext4/ialloc.c
+++ linux-2.6.27.noarch/fs/ext4/ialloc.c
@@ -705,11 +705,12 @@ struct inode *ext4_new_inode(handle_t *h
ret2 = find_group_flex(sb, dir, &group);
if (ret2 == -1) {
ret2 = find_group_other(sb, dir, &group);
- if (ret2 == 0 && once)
+ if (ret2 == 0 && once) {
once = 0;
printk(KERN_NOTICE "ext4: find_group_flex "
"failed, fallback succeeded dir %lu\n",
dir->i_ino);
+ }
}
goto got_group;
}

2009-04-14 11:30:33

by Theodore Ts'o

Subject: Re: [patch] ext4: really print the find_group_flex fallback warning only once

On Mon, Apr 13, 2009 at 07:03:29PM -0400, Chuck Ebbert wrote:
> ext4: really print the find_group_flex fallback warning only once
>
> Missing braces caused the warning to print more than once.

Thanks, applied.

- Ted