2009-05-01 08:47:04

by Nick Dokos

Subject: [PATCH 5/6] [64-bit] (blk_t) cast in ext2fs_new_block2()

Found by code inspection after similar gratuitous cast in
ext2fs_get_free_blocks2() (first patch in this series).

Signed-off-by: Nick Dokos <[email protected]>
---
lib/ext2fs/alloc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/ext2fs/alloc.c b/lib/ext2fs/alloc.c
index 9f11673..a7c8860 100644
--- a/lib/ext2fs/alloc.c
+++ b/lib/ext2fs/alloc.c
@@ -170,7 +170,7 @@ errcode_t ext2fs_new_block2(ext2_filsys fs, blk64_t goal,
(i - fs->super->s_first_data_block) /
EXT2_BLOCKS_PER_GROUP(fs->super));

- if (!ext2fs_fast_test_block_bitmap2(map, (blk_t) i)) {
+ if (!ext2fs_fast_test_block_bitmap2(map, i)) {
*ret = i;
return 0;
}
--
1.6.0.6

2009-05-04 06:21:25

by Valerie Aurora

Subject: Re: [PATCH 5/6] [64-bit] (blk_t) cast in ext2fs_new_block2()

On Fri, May 01, 2009 at 04:47:17AM -0400, Nick Dokos wrote:
> Found by code inspection after similar gratuitous cast in
> ext2fs_get_free_blocks2() (first patch in this series).
>
> Signed-off-by: Nick Dokos <[email protected]>
> ---
> lib/ext2fs/alloc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/ext2fs/alloc.c b/lib/ext2fs/alloc.c
> index 9f11673..a7c8860 100644
> --- a/lib/ext2fs/alloc.c
> +++ b/lib/ext2fs/alloc.c
> @@ -170,7 +170,7 @@ errcode_t ext2fs_new_block2(ext2_filsys fs, blk64_t goal,
> (i - fs->super->s_first_data_block) /
> EXT2_BLOCKS_PER_GROUP(fs->super));
>
> - if (!ext2fs_fast_test_block_bitmap2(map, (blk_t) i)) {
> + if (!ext2fs_fast_test_block_bitmap2(map, i)) {
> *ret = i;
> return 0;
> }
> --
> 1.6.0.6
>

Signed-off-by: Valerie Aurora (Henson) <[email protected]>

-VAL