Sorry for the delay; I've been incredibly busy. I'm guessing you
never actually bothered to build and test the patch which you
submitted?
I tried building with --disable-libuuid, when it tried to compile
e2fsck, it crashed and burned. The reason why was because LIBUUID
wasn't getting set properly:
% grep LIBUUID MCONFIG | head -1
LIBUUID =
And the reason for that is....
On Wed, Jun 03, 2009 at 10:39:05AM +0100, Scott James Remnant wrote:
> +AC_ARG_ENABLE([libuuid],
> +[ --disable-libuuid do not build private uuid library],
> +if test "$enableval" = "no"
> +then
> + if test -z "$PKG_CONFIG"; then
> + AC_MSG_ERROR([pkg-config not installed; please install it.])
> + fi
> +
> + AC_CHECK_LIB(uuid, uuid_generate,
> + [LIBBLKID=`$PKG_CONFIG --libs uuid`;
^^^^^^^^
> + STATIC_LIBBLKID=`$PKG_CONFIG --static --libs uuid`],
^^^^^^^^^^^^^^^
> + [AC_MSG_ERROR([external uuid library not found])],
> + [$LIBUUID])
> + UUID_CMT=#
> + AC_MSG_RESULT([Disabling private uuid library])
I'll have a corrected patch checked into e2fsprogs.
- Ted
On Sun, Jun 28, 2009 at 15:34, Theodore Tso<[email protected]> wrote:
> I'll have a corrected patch checked into e2fsprogs.
Very nice. Thanks!
It seems, that /usr/bin/uuidgen is installed, even when:
--disable-libblkid
--disable-libuuid
--disable-uuidd
is given.
And another thing is your custom "silent build" which can not be
disabled. Our build system requires the command output for fancy
analysis, so it would be good if it could be disabled, like it can for
the kernel (V=1). Any ideas, or do I miss some switch?
Thanks,
Kay
On Tue, Jun 30, 2009 at 12:17:02PM +0200, Kay Sievers wrote:
>
> And another thing is your custom "silent build" which can not be
> disabled. Our build system requires the command output for fancy
> analysis, so it would be good if it could be disabled, like it can for
> the kernel (V=1). Any ideas, or do I miss some switch?
>
Is a configure-level switch all that you need? I hadn't done a
make-level switch because I was trying to avoid adding a requirement
of using GNU make in building e2fsprogs, since it gets used by *BSD
and Solaris systems as well. (And in fact some of the recent UUID bug
fixes come from FreeBSD bug reports, and I suspect FreeBSD will
continue to use UUID library from e2fsprogs rather than pulling in
util-linux-ng....)
- Ted