On Wed, Jul 1, 2009 at 23:43, Theodore Tso<[email protected]> wrote:
> On Tue, Jun 30, 2009 at 12:17:02PM +0200, Kay Sievers wrote:
>>
>> And another thing is your custom "silent build" which can not be
>> disabled. Our build system requires the command output for fancy
>> analysis, so it would be good if it could be disabled, like it can for
>> the kernel (V=1). Any ideas, or do I miss some switch?
>
> Is a configure-level switch all that you need? I hadn't done a
> make-level switch because I was trying to avoid adding a requirement
> of using GNU make in building e2fsprogs, since it gets used by *BSD
> and Solaris systems as well. (And in fact some of the recent UUID bug
> fixes come from FreeBSD bug reports, and I suspect FreeBSD will
> continue to use UUID library from e2fsprogs rather than pulling in
> util-linux-ng....)
Anything would work, that resolves the '@' to nothing and puts out the
command, an environment var or a switch.
In older udev releases, before we switched to automake, I had
something like this, which behaves a bit like the Linux kernel build,
and V=1 switches off the silent mode:
V =
ifeq ($(strip $(V)),)
E = @echo
Q = @
else
E = @\#
Q =
endif
export E Q
...
$(E) " CC " $@
$(Q) $(CC) -c $(CFLAGS) $< -o $@
...
Thanks,
Kay
On Wednesday 01 July 2009 17:52:11 Kay Sievers wrote:
> On Wed, Jul 1, 2009 at 23:43, Theodore Tso<[email protected]> wrote:
> > On Tue, Jun 30, 2009 at 12:17:02PM +0200, Kay Sievers wrote:
> >> And another thing is your custom "silent build" which can not be
> >> disabled. Our build system requires the command output for fancy
> >> analysis, so it would be good if it could be disabled, like it can for
> >> the kernel (V=1). Any ideas, or do I miss some switch?
> >
> > Is a configure-level switch all that you need? I hadn't done a
> > make-level switch because I was trying to avoid adding a requirement
> > of using GNU make in building e2fsprogs, since it gets used by *BSD
> > and Solaris systems as well. (And in fact some of the recent UUID bug
> > fixes come from FreeBSD bug reports, and I suspect FreeBSD will
> > continue to use UUID library from e2fsprogs rather than pulling in
> > util-linux-ng....)
>
> Anything would work, that resolves the '@' to nothing and puts out the
> command, an environment var or a switch.
>
> In older udev releases, before we switched to automake, I had
> something like this, which behaves a bit like the Linux kernel build,
> and V=1 switches off the silent mode:
why not just use automake-1.11's silent-rules option. then you dont have to
waste time reinventing the wheel.
-mike
On Wed, Jul 01, 2009 at 06:35:06PM -0400, Mike Frysinger wrote:
> > In older udev releases, before we switched to automake, I had
> > something like this, which behaves a bit like the Linux kernel build,
> > and V=1 switches off the silent mode:
>
> why not just use automake-1.11's silent-rules option. then you dont have to
> waste time reinventing the wheel.
Because I consider automake the spawn of Satan? :-)
- Ted
On Wednesday 01 July 2009 20:58:58 Theodore Tso wrote:
> On Wed, Jul 01, 2009 at 06:35:06PM -0400, Mike Frysinger wrote:
> > > In older udev releases, before we switched to automake, I had
> > > something like this, which behaves a bit like the Linux kernel build,
> > > and V=1 switches off the silent mode:
> >
> > why not just use automake-1.11's silent-rules option. then you dont have
> > to waste time reinventing the wheel.
>
> Because I consider automake the spawn of Satan? :-)
i'll have you know Satan's wheel is awfully shiny ...
Kay's rules look like they should be fairly straightforward to drop into
e2fsprogs. personally i'd use:
E = @:
when V=1, but this is probably just splitting hairs
-mike