2009-07-03 10:55:59

by Aneesh Kumar K.V

Subject: [PATCH] ext4: Add a missing return in ext4_ext_calc_credits_for_single_extent

When we have space in the extent tree leaf node we should be able to
insert the extent with much less journal credits. The code was doing
proper calculation but missed a return statement.

Reported-by:Andreas Dilger <[email protected]>
Signed-off-by: Aneesh Kumar K.V <[email protected]>
---
fs/ext4/extents.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index f9ab60f..3e8889f 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1977,6 +1977,7 @@ int ext4_ext_calc_credits_for_single_extent(struct inode *inode, int nrblocks,
*/
/* 1 bitmap, 1 block group descriptor */
ret = 2 + EXT4_META_TRANS_BLOCKS(inode->i_sb);
+ return ret;
}
}

--
1.6.3.2.363.gc5764

2009-07-06 03:13:49

by Theodore Ts'o

Subject: Re: [PATCH] ext4: Add a missing return in ext4_ext_calc_credits_for_single_extent

On Fri, Jul 03, 2009 at 04:25:56PM +0530, Aneesh Kumar K.V wrote:
> When we have space in the extent tree leaf node we should be able to
> insert the extent with much less journal credits. The code was doing
> proper calculation but missed a return statement.
>
> Reported-by:Andreas Dilger <[email protected]>
> Signed-off-by: Aneesh Kumar K.V <[email protected]>

Thanks, added to the ext4 patch queue.

- Ted