2009-07-19 17:21:46

by Peng Tao

Subject: [PATCH] ext4: fix build warning when EXT4FS_DEBUG is on

When compiling with EXT4FS_DEBUG on, gcc will complain with following warnings:

linux-2.6/fs/ext4/ialloc.c: In function ‘ext4_count_free_inodes’:
linux-2.6/fs/ext4/ialloc.c:1192: warning: format ‘%lu’ expects type
‘long unsigned int’, but argument 2 has type ‘ext4_group_t’

So add a type cast to suppress it.

Signed-off-by: Peng Tao <[email protected]>
---
fs/ext4/ialloc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 2f64573..cd77f03 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -1189,7 +1189,7 @@ unsigned long ext4_count_free_inodes(struct super_block *sb)

x = ext4_count_free(bitmap_bh, EXT4_INODES_PER_GROUP(sb) / 8);
printk(KERN_DEBUG "group %lu: stored = %d, counted = %lu\n",
- i, ext4_free_inodes_count(sb, gdp), x);
+ (unsigned long)i, ext4_free_inodes_count(sb, gdp), x);
bitmap_count += x;
}
brelse(bitmap_bh);
--
1.6.2-rc2.GIT

2009-07-28 01:47:31

by Theodore Ts'o

Subject: Re: [PATCH] ext4: fix build warning when EXT4FS_DEBUG is on

On Mon, Jul 20, 2009 at 01:20:57AM +0800, Peng Tao wrote:
> When compiling with EXT4FS_DEBUG on, gcc will complain with following warnings:
>
> linux-2.6/fs/ext4/ialloc.c: In function ‘ext4_count_free_inodes’:
> linux-2.6/fs/ext4/ialloc.c:1192: warning: format ‘%lu’ expects type
> ‘long unsigned int’, but argument 2 has type ‘ext4_group_t’
>
> So add a type cast to suppress it.
>
> Signed-off-by: Peng Tao <[email protected]>

Thanks, applied to the ext4 patch queue.

- Ted