2011-02-06 04:27:45

by Coly Li

Subject: [PATCH 4/5] mballoc: change comments to ac_g_ex

Current comments to ac_g_ex, the member of struct
ext4_allocation_context is,
/* goal request (after normalization) */
This is a little bit confused. In order to make it easier to be
understood, this patch modify the comments as,
/* goal request (normalized ac_o_ex) */
which means ac_g_ex is a normalized value of ac_o_ex.

Signed-off-by: Coly Li <[email protected]>
Cc: Alex Tomas <[email protected]>
Cc: Theodore Tso <[email protected]>
---
fs/ext4/mballoc.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
index b619322..22bd4d7 100644
--- a/fs/ext4/mballoc.h
+++ b/fs/ext4/mballoc.h
@@ -169,7 +169,7 @@ struct ext4_allocation_context {
/* original request */
struct ext4_free_extent ac_o_ex;

- /* goal request (after normalization) */
+ /* goal request (normalized ac_o_ex) */
struct ext4_free_extent ac_g_ex;

/* the best found extent */
--
1.7.3.4

2011-02-24 19:08:24

by Theodore Ts'o

Subject: Re: [PATCH 4/5] mballoc: change comments to ac_g_ex

On Sun, Feb 06, 2011 at 12:54:08PM +0800, Coly Li wrote:
> Current comments to ac_g_ex, the member of struct
> ext4_allocation_context is,
> /* goal request (after normalization) */
> This is a little bit confused. In order to make it easier to be
> understood, this patch modify the comments as,
> /* goal request (normalized ac_o_ex) */
> which means ac_g_ex is a normalized value of ac_o_ex.
>
> Signed-off-by: Coly Li <[email protected]>
> Cc: Alex Tomas <[email protected]>
> Cc: Theodore Tso <[email protected]>

Added to the ext4 patch queue, thanks.

I used a much simpler patch comment:

ext4: clarify description of ac_g_ex in struct ext4_allocation_context

Signed-off-by: Coly Li <[email protected]>
Cc: Alex Tomas <[email protected]>
Cc: Theodore Tso <[email protected]>

- Ted