2011-03-17 01:56:55

by Robin Dong

Subject: [PATCH] ext4: critical info format fix in __ext4_grp_locked_error

From: Robin Dong <[email protected]>

When we do performence-testing on ext4 filesystem, we observe a warning like this:

"[ 1684.113205] EXT4-fs error (device sda7): ext4_mb_generate_buddy:718: group 259825901 blocks in bitmap, 26057 in gd"

indeed, it should be

"group 2598, 25901 blocks in bitmap, 26057 in gd"

Reviewed-by: Coly Li <[email protected]>
Signed-off-by: Robin Dong <[email protected]>
---
fs/ext4/super.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index f6a318f..bb38475 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -594,7 +594,7 @@ __acquires(bitlock)

vaf.fmt = fmt;
vaf.va = &args;
- printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: group %u",
+ printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: group %u, ",
sb->s_id, function, line, grp);
if (ino)
printk(KERN_CONT "inode %lu: ", ino);
--
1.7.3.5

2011-03-17 02:07:45

by Greg KH

Subject: Re: [stable] [PATCH] ext4: critical info format fix in __ext4_grp_locked_error

On Thu, Mar 17, 2011 at 09:56:31AM +0800, Robin Dong wrote:
> From: Robin Dong <[email protected]>
>
> When we do performence-testing on ext4 filesystem, we observe a warning like this:
>
> "[ 1684.113205] EXT4-fs error (device sda7): ext4_mb_generate_buddy:718: group 259825901 blocks in bitmap, 26057 in gd"
>
> indeed, it should be
>
> "group 2598, 25901 blocks in bitmap, 26057 in gd"
>
> Reviewed-by: Coly Li <[email protected]>
> Signed-off-by: Robin Dong <[email protected]>
> ---

<formletter>

This is not how you get a patch applied to the stable tree. Please read
Documentation/stable_kernel_rules.txt for how to properly do this.

thanks,

greg k-h

</formletter>