2011-09-23 20:51:47

by Hartley Sweeten

Subject: [PATCH] ext2/xattr_security.c: local functions should be static

This quiets the sparse noise:

warning: symbol 'ext2_initxattrs' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Jan Kara <[email protected]>

---

diff --git a/fs/ext2/xattr_security.c b/fs/ext2/xattr_security.c
index c922adc..ed1a5d5 100644
--- a/fs/ext2/xattr_security.c
+++ b/fs/ext2/xattr_security.c
@@ -46,7 +46,7 @@ ext2_xattr_security_set(struct dentry *dentry, const char *name,
value, size, flags);
}

-int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+static int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
void *fs_info)
{
const struct xattr *xattr;

2011-10-04 23:37:05

by Jan Kara

Subject: Re: [PATCH] ext2/xattr_security.c: local functions should be static

On Fri 23-09-11 13:51:24, H Hartley Sweeten wrote:
> This quiets the sparse noise:
>
> warning: symbol 'ext2_initxattrs' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Jan Kara <[email protected]>
Hmm, this patch doesn't seem to be against latest Linus kernel... At
least I don't see ext2_initxattrs() there - although I remember seeing
patches adding this function flying somewhere.

Honza

> diff --git a/fs/ext2/xattr_security.c b/fs/ext2/xattr_security.c
> index c922adc..ed1a5d5 100644
> --- a/fs/ext2/xattr_security.c
> +++ b/fs/ext2/xattr_security.c
> @@ -46,7 +46,7 @@ ext2_xattr_security_set(struct dentry *dentry, const char *name,
> value, size, flags);
> }
>
> -int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> +static int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> void *fs_info)
> {
> const struct xattr *xattr;
--
Jan Kara <[email protected]>
SUSE Labs, CR