2011-09-23 22:14:19

by Hartley Sweeten

Subject: [PATCH] ext4/fsync.c: functions should not be declared extern

The function declaration in ext4.h is already marked extern. The function
definition should not have the tag.

This quiets the sparse noise:

warning: function 'ext4_flush_completed_IO' with external linkage has definition

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: "Theodore Ts'o" <[email protected]>
Cc: Andreas Dilger <[email protected]>

---

diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
index 036f78f..c942924 100644
--- a/fs/ext4/fsync.c
+++ b/fs/ext4/fsync.c
@@ -75,7 +75,7 @@ static void dump_completed_IO(struct inode * inode)
* to written.
* The function return the number of pending IOs on success.
*/
-extern int ext4_flush_completed_IO(struct inode *inode)
+int ext4_flush_completed_IO(struct inode *inode)
{
ext4_io_end_t *io;
struct ext4_inode_info *ei = EXT4_I(inode);

2011-10-12 03:09:52

by Theodore Ts'o

Subject: Re: [PATCH] ext4/fsync.c: functions should not be declared extern

On Fri, Sep 23, 2011 at 03:14:01PM -0700, H Hartley Sweeten wrote:
> The function declaration in ext4.h is already marked extern. The function
> definition should not have the tag.
>
> This quiets the sparse noise:
>
> warning: function 'ext4_flush_completed_IO' with external linkage has definition
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: "Theodore Ts'o" <[email protected]>
> Cc: Andreas Dilger <[email protected]>

Thanks, applied.

- Ted