2011-09-23 22:19:55

by Hartley Sweeten

Subject: [PATCH] ext4/ialloc.c: functions should not be declared extern

The function declaration in ext4.h is already marked extern.  The function
definition should not have the tag.

This quiets the sparse noise:

warning: function 'ext4_init_inode_table' with external linkage has definition

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: "Theodore Ts'o" <[email protected]>
Cc: Andreas Dilger <[email protected]>

---

diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index fd96ea1..ef9bdd6 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -1235,7 +1235,7 @@ unsigned long ext4_count_dirs(struct super_block * sb)
* inode allocation from the current group, so we take alloc_sem lock, to
* block ext4_claim_inode until we are finished.
*/
-extern int ext4_init_inode_table(struct super_block *sb, ext4_group_t group,
+int ext4_init_inode_table(struct super_block *sb, ext4_group_t group,
int barrier)
{
struct ext4_group_info *grp = ext4_get_group_info(sb, group);

2011-10-12 03:10:01

by Theodore Ts'o

Subject: Re: [PATCH] ext4/ialloc.c: functions should not be declared extern

On Fri, Sep 23, 2011 at 03:19:45PM -0700, H Hartley Sweeten wrote:
> The function declaration in ext4.h is already marked extern. ?The function
> definition should not have the tag.
>
> This quiets the sparse noise:
>
> warning: function 'ext4_init_inode_table' with external linkage has definition
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: "Theodore Ts'o" <[email protected]>
> Cc: Andreas Dilger <[email protected]>

Thanks, applied.

- Ted