2011-09-23 22:32:56

by Hartley Sweeten

Subject: [PATCH] ext4/extents.c: quiet sparse noise about plain integer as NULL pointer

The third parameter to ext4_free_blocks is a struct buffer_head *. This
parameter should be NULL not 0.

This quiets the sparse noise:

warning: Using plain integer as NULL pointer

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: "Theodore Ts'o" <[email protected]>
Cc: Andreas Dilger <[email protected]>

---

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 57cf568..97e8d2b 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2238,7 +2238,7 @@ static int ext4_remove_blocks(handle_t *handle, struct inode *inode,
start = ext4_ext_pblock(ex);

ext_debug("free first %u blocks starting %llu\n", num, start);
- ext4_free_blocks(handle, inode, 0, start, num, flags);
+ ext4_free_blocks(handle, inode, NULL, start, num, flags);

} else {
printk(KERN_INFO "strange request: removal(2) "

2011-10-12 03:11:22

by Theodore Ts'o

Subject: Re: [PATCH] ext4/extents.c: quiet sparse noise about plain integer as NULL pointer

On Fri, Sep 23, 2011 at 03:32:44PM -0700, H Hartley Sweeten wrote:
> The third parameter to ext4_free_blocks is a struct buffer_head *. This
> parameter should be NULL not 0.
>
> This quiets the sparse noise:
>
> warning: Using plain integer as NULL pointer
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: "Theodore Ts'o" <[email protected]>
> Cc: Andreas Dilger <[email protected]>

Thanks, applied.

- Ted