2012-04-16 13:35:03

by Zheng Liu

Subject: [PATCH] debugfs: cleanup in do_show_debugfs_params

From: Zheng Liu <[email protected]>

Remove 'out' variable and replace fprintf with printf.

Signed-off-by: Zheng Liu <[email protected]>
---
debugfs/debugfs.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
index 590468d..99281ac 100644
--- a/debugfs/debugfs.c
+++ b/debugfs/debugfs.c
@@ -1973,12 +1973,10 @@ void do_rmdir(int argc, char *argv[])
void do_show_debugfs_params(int argc EXT2FS_ATTR((unused)),
char *argv[] EXT2FS_ATTR((unused)))
{
- FILE *out = stdout;

2012-04-16 14:21:07

by Steven Liu

Subject: Re: [PATCH] debugfs: cleanup in do_show_debugfs_params

Hi Zheng Liu,

What dose this mean, you use printf and not use stdout?


Reviewed-By Steven Liu <[email protected]>

2012/4/16 Zheng Liu <[email protected]>:
> From: Zheng Liu <[email protected]>
>
> Remove 'out' variable and replace fprintf with printf.
>
> Signed-off-by: Zheng Liu <[email protected]>
> ---
> ?debugfs/debugfs.c | ? ?6 ++----
> ?1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> index 590468d..99281ac 100644
> --- a/debugfs/debugfs.c
> +++ b/debugfs/debugfs.c
> @@ -1973,12 +1973,10 @@ void do_rmdir(int argc, char *argv[])
> ?void do_show_debugfs_params(int argc EXT2FS_ATTR((unused)),
> ? ? ? ? ? ? ? ? ? ? ? ? ? ?char *argv[] EXT2FS_ATTR((unused)))
> ?{
> - ? ? ? FILE *out = stdout;
> -
> ? ? ? ?if (current_fs)
> - ? ? ? ? ? ? ? fprintf(out, "Open mode: read-%s\n",
> + ? ? ? ? ? ? ? printf("Open mode: read-%s\n",
> ? ? ? ? ? ? ? ? ? ? ? ?current_fs->flags & EXT2_FLAG_RW ? "write" : "only");
> - ? ? ? fprintf(out, "Filesystem in use: %s\n",
> + ? ? ? printf("Filesystem in use: %s\n",
> ? ? ? ? ? ? ? ?current_fs ? current_fs->device_name : "--none--");
> ?}
>
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html

2012-04-16 14:34:46

by Zheng Liu

Subject: Re: [PATCH] debugfs: cleanup in do_show_debugfs_params

On Mon, Apr 16, 2012 at 10:21:05PM +0800, Steven Liu wrote:
> Hi Zheng Liu,
>
> What dose this mean, you use printf and not use stdout?

printf() is the same as fprintf(stdout, ...). So I just remove 'out'
variable. Am I missing something?

Regards,
Zheng

>
>
> Reviewed-By Steven Liu <[email protected]>
>
> 2012/4/16 Zheng Liu <[email protected]>:
> > From: Zheng Liu <[email protected]>
> >
> > Remove 'out' variable and replace fprintf with printf.
> >
> > Signed-off-by: Zheng Liu <[email protected]>
> > ---
> >  debugfs/debugfs.c |    6 ++----
> >  1 files changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> > index 590468d..99281ac 100644
> > --- a/debugfs/debugfs.c
> > +++ b/debugfs/debugfs.c
> > @@ -1973,12 +1973,10 @@ void do_rmdir(int argc, char *argv[])
> >  void do_show_debugfs_params(int argc EXT2FS_ATTR((unused)),
> >                            char *argv[] EXT2FS_ATTR((unused)))
> >  {
> > -       FILE *out = stdout;
> > -
> >        if (current_fs)
> > -               fprintf(out, "Open mode: read-%s\n",
> > +               printf("Open mode: read-%s\n",
> >                        current_fs->flags & EXT2_FLAG_RW ? "write" : "only");
> > -       fprintf(out, "Filesystem in use: %s\n",
> > +       printf("Filesystem in use: %s\n",
> >                current_fs ? current_fs->device_name : "--none--");
> >  }
> >
> > --
> > 1.7.4.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to [email protected]
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

2012-04-24 18:33:27

by Theodore Ts'o

Subject: Re: [PATCH] debugfs: cleanup in do_show_debugfs_params

On Mon, Apr 16, 2012 at 09:41:26PM +0800, Zheng Liu wrote:
> From: Zheng Liu <[email protected]>
>
> Remove 'out' variable and replace fprintf with printf.
>
> Signed-off-by: Zheng Liu <[email protected]>

Thanks, applied.

- Ted