2012-06-13 07:47:13

by Liu Bo

[permalink] [raw]

Subject: [PATCH] E2fsprogs: add missing usage for No_COW

---

Add the missing usage for No_COW since we've supported No_COW flag.

Signed-off-by: Liu Bo <[email protected]>
---
misc/chattr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/misc/chattr.c b/misc/chattr.c
index 141ea6e..24254cc 100644
--- a/misc/chattr.c
+++ b/misc/chattr.c
@@ -83,7 +83,7 @@ static unsigned long sf;
static void usage(void)
{
fprintf(stderr,
- _("Usage: %s [-RVf] [-+=AacDdeijsSu] [-v version] files...\n"),
+ _("Usage: %s [-RVf] [-+=AacDdeijsSuC] [-v version] files...\n"),
program_name);
exit(1);
}
--
1.6.5.2

2012-06-13 08:38:17

by Roman Mamedov

[permalink] [raw]

Subject: Re: [PATCH] E2fsprogs: add missing usage for No_COW

---

On Wed, 13 Jun 2012 15:47:13 +0800
Liu Bo <[email protected]> wrote:

> Add the missing usage for No_COW since we've supported No_COW flag.
>
> Signed-off-by: Liu Bo <[email protected]>
> ---
> misc/chattr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/misc/chattr.c b/misc/chattr.c
> index 141ea6e..24254cc 100644
> --- a/misc/chattr.c
> +++ b/misc/chattr.c
> @@ -83,7 +83,7 @@ static unsigned long sf;
> static void usage(void)
> {
> fprintf(stderr,
> - _("Usage: %s [-RVf] [-+=AacDdeijsSu] [-v version] files...\n"),
> + _("Usage: %s [-RVf] [-+=AacDdeijsSuC] [-v version] files...\n"),
> program_name);
> exit(1);
> }

These were sorted alphabetically so the better way would be to use AaCcDdeijsSu

--
With respect,
Roman

~~~~~~~~~~~~~~~~~~~~~~~~~~~
"Stallman had a printer,
with code he could not see.
So he began to tinker,
and set the software free."

---

Attachments:

signature.asc (198.00 B)

2012-06-14 02:47:28

by Theodore Ts'o

[permalink] [raw]

Subject: Re: [PATCH] E2fsprogs: add missing usage for No_COW

---

On Wed, Jun 13, 2012 at 03:47:13PM +0800, Liu Bo wrote:
> Add the missing usage for No_COW since we've supported No_COW flag.
>
> Signed-off-by: Liu Bo <[email protected]>

Applied, thanks.

- Ted