2012-08-06 20:08:54

by Jim Keniston

Subject: [PATCH] e2fsprogs: e2fsck_handle_read_error - pass along negative count

When passed a negative count (indicating a byte count rather than
a block count) e2fsck_handle_read_error() treats the data as a full
block, causing unix_write_blk64() (which can handle negative counts
just fine) to try to write too much. Given a faulty block device,
this resulted in a SEGV when unix_write_blk64() read past the bottom
of the stack copying the data to cache. (check_backup_super_block ->
unix_read_blk64 -> raw_read_blk -> e2fsck_handle_read_error)

Signed-off-by: Jim Keniston <[email protected]>
Signed-off-by: Dan Streetman <[email protected]>
Reviewed-by: Mingming Cao <[email protected]>
Reported-by: Alex Friedman <[email protected]>
---

e2fsck/ehandler.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/e2fsck/ehandler.c b/e2fsck/ehandler.c
index 6eecf33..6dddf9c 100644
--- a/e2fsck/ehandler.c
+++ b/e2fsck/ehandler.c
@@ -60,7 +60,7 @@ static errcode_t e2fsck_handle_read_error(io_channel channel,
preenhalt(ctx);
if (ask(ctx, _("Ignore error"), 1)) {
if (ask(ctx, _("Force rewrite"), 1))
- io_channel_write_blk64(channel, block, 1, data);
+ io_channel_write_blk64(channel, block, count, data);
return 0;
}

2012-08-06 22:55:28

by Theodore Ts'o

Subject: Re: [PATCH] e2fsprogs: e2fsck_handle_read_error - pass along negative count

On Mon, Aug 06, 2012 at 01:05:53PM -0700, Jim Keniston wrote:
> When passed a negative count (indicating a byte count rather than
> a block count) e2fsck_handle_read_error() treats the data as a full
> block, causing unix_write_blk64() (which can handle negative counts
> just fine) to try to write too much. Given a faulty block device,
> this resulted in a SEGV when unix_write_blk64() read past the bottom
> of the stack copying the data to cache. (check_backup_super_block ->
> unix_read_blk64 -> raw_read_blk -> e2fsck_handle_read_error)
>
> Signed-off-by: Jim Keniston <[email protected]>
> Signed-off-by: Dan Streetman <[email protected]>
> Reviewed-by: Mingming Cao <[email protected]>
> Reported-by: Alex Friedman <[email protected]>

Thanks, applied! I changed the one-line summary to read:

e2fsck: fix potential segv when handling a read error in a superblock

- Ted