2012-08-02 10:30:50

by Sachin Kamat

Subject: [PATCH] ext4: Replace plain integer with NULL in super.c file

Fixes the following sparse warning:
fs/ext4/super.c:1672:45: warning: Using plain integer as NULL pointer

Signed-off-by: Sachin Kamat <[email protected]>
---
fs/ext4/super.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index d76ec82..1b000a6 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1669,7 +1669,7 @@ static int parse_options(char *options, struct super_block *sb,
* Initialize args struct so we know whether arg was
* found; some options take optional arguments.
*/
- args[0].to = args[0].from = 0;
+ args[0].to = args[0].from = NULL;
token = match_token(p, tokens, args);
if (handle_mount_opt(sb, p, token, args, journal_devnum,
journal_ioprio, is_remount) < 0)
--
1.7.4.1

2012-08-13 16:16:09

by Sachin Kamat

Subject: Re: [PATCH] ext4: Replace plain integer with NULL in super.c file

ping...

On 2 August 2012 15:59, Sachin Kamat <[email protected]> wrote:
> Fixes the following sparse warning:
> fs/ext4/super.c:1672:45: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> fs/ext4/super.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index d76ec82..1b000a6 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1669,7 +1669,7 @@ static int parse_options(char *options, struct super_block *sb,
> * Initialize args struct so we know whether arg was
> * found; some options take optional arguments.
> */
> - args[0].to = args[0].from = 0;
> + args[0].to = args[0].from = NULL;
> token = match_token(p, tokens, args);
> if (handle_mount_opt(sb, p, token, args, journal_devnum,
> journal_ioprio, is_remount) < 0)
> --
> 1.7.4.1
>



--
With warm regards,
Sachin

2012-08-17 23:21:14

by Theodore Ts'o

Subject: Re: [PATCH] ext4: Replace plain integer with NULL in super.c file

Applied. Apologies for the delay; I had some higher priority patches
I needed to deal with first....

- Ted