2013-06-24 06:39:53

by Kazuya Mio

Subject: [PATCH 1/2 V2] mke2fs: fix force option to create filesystem on mounted device

According to mke2fs man, we can create a filesystem on the mounted device
when -FF option is specified.
However, currently we have to specify -F option third to force mke2fs.
This patch fixes the problem.

Signed-off-by: Kazuya Mio <[email protected]>
---
misc/util.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/misc/util.c b/misc/util.c
index 6c93e1c..40c8858 100644
--- a/misc/util.c
+++ b/misc/util.c
@@ -150,7 +150,7 @@ void check_mount(const char *device, int force, const char *type)
}
if (mount_flags & EXT2_MF_MOUNTED) {
fprintf(stderr, _("%s is mounted; "), device);
- if (force > 2) {
+ if (force >= 2) {
fputs(_("mke2fs forced anyway. Hope /etc/mtab is "
"incorrect.\n"), stderr);
return;
@@ -162,7 +162,7 @@ void check_mount(const char *device, int force, const char *type)
if (mount_flags & EXT2_MF_BUSY) {
fprintf(stderr, _("%s is apparently in use by the system; "),
device);
- if (force > 2) {
+ if (force >= 2) {
fputs(_("mke2fs forced anyway.\n"), stderr);
return;
}

2013-06-27 06:33:50

by Zheng Liu

Subject: Re: [PATCH 1/2 V2] mke2fs: fix force option to create filesystem on mounted device

On Mon, Jun 24, 2013 at 03:28:59PM +0900, Kazuya Mio wrote:
> According to mke2fs man, we can create a filesystem on the mounted device
> when -FF option is specified.
> However, currently we have to specify -F option third to force mke2fs.
> This patch fixes the problem.
>
> Signed-off-by: Kazuya Mio <[email protected]>

Reviewed-by: Zheng Liu <[email protected]>

- Zheng

> ---
> misc/util.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/misc/util.c b/misc/util.c
> index 6c93e1c..40c8858 100644
> --- a/misc/util.c
> +++ b/misc/util.c
> @@ -150,7 +150,7 @@ void check_mount(const char *device, int force, const char *type)
> }
> if (mount_flags & EXT2_MF_MOUNTED) {
> fprintf(stderr, _("%s is mounted; "), device);
> - if (force > 2) {
> + if (force >= 2) {
> fputs(_("mke2fs forced anyway. Hope /etc/mtab is "
> "incorrect.\n"), stderr);
> return;
> @@ -162,7 +162,7 @@ void check_mount(const char *device, int force, const char *type)
> if (mount_flags & EXT2_MF_BUSY) {
> fprintf(stderr, _("%s is apparently in use by the system; "),
> device);
> - if (force > 2) {
> + if (force >= 2) {
> fputs(_("mke2fs forced anyway.\n"), stderr);
> return;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2013-06-27 09:05:27

by Lukas Czerner

Subject: Re: [PATCH 1/2 V2] mke2fs: fix force option to create filesystem on mounted device

On Mon, 24 Jun 2013, Kazuya Mio wrote:

> Date: Mon, 24 Jun 2013 15:28:59 +0900
> From: Kazuya Mio <[email protected]>
> To: Andreas Dilger <[email protected]>, [email protected]
> Cc: [email protected]
> Subject: [PATCH 1/2 V2] mke2fs: fix force option to create filesystem on
> mounted device
>
> According to mke2fs man, we can create a filesystem on the mounted device
> when -FF option is specified.
> However, currently we have to specify -F option third to force mke2fs.

Oh, you mean we have to specify -F option three times ? It took me
some time to understand. Please rephrase the description.

Otherwise the patch looks good.

Thanks!
-Lukas

> This patch fixes the problem.
>
> Signed-off-by: Kazuya Mio <[email protected]>
> ---
> misc/util.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/misc/util.c b/misc/util.c
> index 6c93e1c..40c8858 100644
> --- a/misc/util.c
> +++ b/misc/util.c
> @@ -150,7 +150,7 @@ void check_mount(const char *device, int force, const char *type)
> }
> if (mount_flags & EXT2_MF_MOUNTED) {
> fprintf(stderr, _("%s is mounted; "), device);
> - if (force > 2) {
> + if (force >= 2) {
> fputs(_("mke2fs forced anyway. Hope /etc/mtab is "
> "incorrect.\n"), stderr);
> return;
> @@ -162,7 +162,7 @@ void check_mount(const char *device, int force, const char *type)
> if (mount_flags & EXT2_MF_BUSY) {
> fprintf(stderr, _("%s is apparently in use by the system; "),
> device);
> - if (force > 2) {
> + if (force >= 2) {
> fputs(_("mke2fs forced anyway.\n"), stderr);
> return;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>