2013-11-11 19:32:18

by Eric Whitney

Subject: [PATCH] libext2fs: fix printf conversion spec in tst_iscan.c

A recent patch to fix blk_t to blk64_t assignment mismatches in
e2fsprogs (commit 4dbfd79d1458ce1259b951377e341aeb6197f8c1) created
a printf conversion spec / argument type mismatch in tst_iscan.c.
Fix this to avoid truncation of the printed value and to silence
a compiler warning seen when "make check" is run.

Signed-off-by: Eric Whitney <[email protected]>
---
lib/ext2fs/tst_iscan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ext2fs/tst_iscan.c b/lib/ext2fs/tst_iscan.c
index a95296c..70bfbec 100644
--- a/lib/ext2fs/tst_iscan.c
+++ b/lib/ext2fs/tst_iscan.c
@@ -182,7 +182,7 @@ static void check_map(void)

for (i=0; test_vec[i]; i++) {
if (ext2fs_test_block_bitmap2(touched_map, test_vec[i])) {
- printf("Bad block was touched --- %u\n", test_vec[i]);
+ printf("Bad block was touched --- %llu\n", test_vec[i]);
failed++;
first_no_comma = 1;
}
--
1.8.3.2

2013-12-03 04:37:54

by Theodore Ts'o

Subject: Re: [PATCH] libext2fs: fix printf conversion spec in tst_iscan.c

On Mon, Nov 11, 2013 at 02:32:13PM -0500, Eric Whitney wrote:
> A recent patch to fix blk_t to blk64_t assignment mismatches in
> e2fsprogs (commit 4dbfd79d1458ce1259b951377e341aeb6197f8c1) created
> a printf conversion spec / argument type mismatch in tst_iscan.c.
> Fix this to avoid truncation of the printed value and to silence
> a compiler warning seen when "make check" is run.
>
> Signed-off-by: Eric Whitney <[email protected]>

Thanks, applied.

- Ted