2013-12-20 05:11:25

by Yongqiang Yang

[permalink] [raw]
Subject: Fwd: [RESEND PATCH 1/2] ext4: fix a typo in extents.c

From: Yongqiang Yang <[email protected]>

Signed-off-by: Yongqiang Yang <[email protected]>
---
fs/ext4/extents.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 54d52af..3654dac 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3492,7 +3492,7 @@ static int
ext4_ext_convert_to_initialized(handle_t *handle,
WARN_ON(map->m_lblk < ee_block);
/*
* It is safe to convert extent to initialized via explicit
- * zeroout only if extent is fully insde i_size or new_size.
+ * zeroout only if extent is fully inside i_size or new_size.
*/
split_flag |= ee_block + ee_len <= eof_block ? EXT4_EXT_MAY_ZEROOUT : 0;

--
1.8.5.2


2013-12-20 05:11:59

by Yongqiang Yang

[permalink] [raw]
Subject: Fwd: [RESEND PATCH 1/2] ext4: fix a typo in extents.c

From: Yongqiang Yang <[email protected]>

Signed-off-by: Yongqiang Yang <[email protected]>
---
fs/ext4/extents.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 54d52af..3654dac 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3492,7 +3492,7 @@ static int
ext4_ext_convert_to_initialized(handle_t *handle,
WARN_ON(map->m_lblk < ee_block);
/*
* It is safe to convert extent to initialized via explicit
- * zeroout only if extent is fully insde i_size or new_size.
+ * zeroout only if extent is fully inside i_size or new_size.
*/
split_flag |= ee_block + ee_len <= eof_block ? EXT4_EXT_MAY_ZEROOUT : 0;

--
1.8.5.2

2013-12-23 12:17:35

by Carlos Maiolino

[permalink] [raw]
Subject: Re: Fwd: [RESEND PATCH 1/2] ext4: fix a typo in extents.c

On Fri, Dec 20, 2013 at 01:11:38PM +0800, Yongqiang Yang wrote:
> From: Yongqiang Yang <[email protected]>
>
> Signed-off-by: Yongqiang Yang <[email protected]>
> ---
> fs/ext4/extents.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 54d52af..3654dac 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -3492,7 +3492,7 @@ static int
> ext4_ext_convert_to_initialized(handle_t *handle,
> WARN_ON(map->m_lblk < ee_block);
> /*
> * It is safe to convert extent to initialized via explicit
> - * zeroout only if extent is fully insde i_size or new_size.
> + * zeroout only if extent is fully inside i_size or new_size.
> */
> split_flag |= ee_block + ee_len <= eof_block ? EXT4_EXT_MAY_ZEROOUT : 0;
>
Looks good
Reviewed-by: Carlos Maiolino <[email protected]>
--
Carlos

2014-01-06 14:52:18

by Theodore Ts'o

[permalink] [raw]
Subject: Re: Fwd: [RESEND PATCH 1/2] ext4: fix a typo in extents.c

On Fri, Dec 20, 2013 at 01:11:03PM +0800, Yongqiang Yang wrote:
> From: Yongqiang Yang <[email protected]>
>
> Signed-off-by: Yongqiang Yang <[email protected]>

Thanks, applied.

- Ted