2014-06-10 14:41:24

by Himangi Saraogi

Subject: [PATCH] fs/ext2/super.c: Drop memory allocation cast

Drop cast on the result of kmem_cache_alloc.

The semantic patch that makes this change is as follows:

// <smpl>
@@
type T;
@@

- (T *)
(\(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\|
kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\)(...))
// </smpl>

Signed-off-by: Himangi Saraogi <[email protected]>
Acked-by: Julia Lawall <[email protected]>
---
fs/ext2/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 3750031..b88edc0 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -161,7 +161,7 @@ static struct kmem_cache * ext2_inode_cachep;
static struct inode *ext2_alloc_inode(struct super_block *sb)
{
struct ext2_inode_info *ei;
- ei = (struct ext2_inode_info *)kmem_cache_alloc(ext2_inode_cachep, GFP_KERNEL);
+ ei = kmem_cache_alloc(ext2_inode_cachep, GFP_KERNEL);
if (!ei)
return NULL;
ei->i_block_alloc_info = NULL;
--
1.9.1

2014-06-11 12:14:54

by Jan Kara

Subject: Re: [PATCH] fs/ext2/super.c: Drop memory allocation cast

On Tue 10-06-14 20:11:18, Himangi Saraogi wrote:
> Drop cast on the result of kmem_cache_alloc.
>
> The semantic patch that makes this change is as follows:
>
> // <smpl>
> @@
> type T;
> @@
>
> - (T *)
> (\(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\|
> kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\)(...))
> // </smpl>
>
> Signed-off-by: Himangi Saraogi <[email protected]>
> Acked-by: Julia Lawall <[email protected]>
Merged to my tree. Thanks!

Honza
> ---
> fs/ext2/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 3750031..b88edc0 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -161,7 +161,7 @@ static struct kmem_cache * ext2_inode_cachep;
> static struct inode *ext2_alloc_inode(struct super_block *sb)
> {
> struct ext2_inode_info *ei;
> - ei = (struct ext2_inode_info *)kmem_cache_alloc(ext2_inode_cachep, GFP_KERNEL);
> + ei = kmem_cache_alloc(ext2_inode_cachep, GFP_KERNEL);
> if (!ei)
> return NULL;
> ei->i_block_alloc_info = NULL;
> --
> 1.9.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR