2015-03-24 13:11:48

by Maurizio Lombardi

Subject: [PATCH] ext4: remove unnecessary lock/unlock of i_block_reservation_lock

This is a leftover of commit 71d4f7d032149b935a26eb3ff85c6c837f3714e1

Signed-off-by: Maurizio Lombardi <[email protected]>
---
fs/ext4/balloc.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 83a6f49..2072c70 100644
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
@@ -641,8 +641,6 @@ ext4_fsblk_t ext4_new_meta_blocks(handle_t *handle, struct inode *inode,
* fail EDQUOT for metdata, but we do account for it.
*/
if (!(*errp) && (flags & EXT4_MB_DELALLOC_RESERVED)) {
- spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
- spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
dquot_alloc_block_nofail(inode,
EXT4_C2B(EXT4_SB(inode->i_sb), ar.len));
}
--
Maurizio Lombardi

2015-03-24 14:53:57

by Lukas Czerner

Subject: Re: [PATCH] ext4: remove unnecessary lock/unlock of i_block_reservation_lock

On Tue, 24 Mar 2015, Maurizio Lombardi wrote:

> Date: Tue, 24 Mar 2015 14:11:44 +0100
> From: Maurizio Lombardi <[email protected]>
> To: [email protected]
> Cc: [email protected]
> Subject: [PATCH] ext4: remove unnecessary lock/unlock of
> i_block_reservation_lock
>
> This is a leftover of commit 71d4f7d032149b935a26eb3ff85c6c837f3714e1

Ah yes, seems we're only now finding missing leftovers from that
commit :)

Reviewed-by: Lukas Czerner <[email protected]>

Thanks!
-Lukas

>
> Signed-off-by: Maurizio Lombardi <[email protected]>
> ---
> fs/ext4/balloc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
> index 83a6f49..2072c70 100644
> --- a/fs/ext4/balloc.c
> +++ b/fs/ext4/balloc.c
> @@ -641,8 +641,6 @@ ext4_fsblk_t ext4_new_meta_blocks(handle_t *handle, struct inode *inode,
> * fail EDQUOT for metdata, but we do account for it.
> */
> if (!(*errp) && (flags & EXT4_MB_DELALLOC_RESERVED)) {
> - spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
> - spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
> dquot_alloc_block_nofail(inode,
> EXT4_C2B(EXT4_SB(inode->i_sb), ar.len));
> }
>

2015-04-03 04:04:10

by Theodore Ts'o

Subject: Re: [PATCH] ext4: remove unnecessary lock/unlock of i_block_reservation_lock

On Tue, Mar 24, 2015 at 02:11:44PM +0100, Maurizio Lombardi wrote:
> This is a leftover of commit 71d4f7d032149b935a26eb3ff85c6c837f3714e1
>
> Signed-off-by: Maurizio Lombardi <[email protected]>

Thanks, applied.

- Ted