2015-09-28 13:50:37

by Yaowei Bai

Subject: [PATCH 07/17] fs/ext4: remove unnecessary new_valid_dev check

As new_valid_dev always returns 1, so !new_valid_dev check is not
needed, remove it.

Signed-off-by: Yaowei Bai <[email protected]>
---
fs/ext4/namei.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 9f61e76..41b6cc8 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2469,9 +2469,6 @@ static int ext4_mknod(struct inode *dir, struct dentry *dentry,
struct inode *inode;
int err, credits, retries = 0;

- if (!new_valid_dev(rdev))
- return -EINVAL;
-
err = dquot_initialize(dir);
if (err)
return err;
--
1.9.1

2015-10-29 18:09:01

by Theodore Ts'o

Subject: Re: [PATCH 07/17] fs/ext4: remove unnecessary new_valid_dev check

On Mon, Sep 28, 2015 at 09:50:37PM +0800, Yaowei Bai wrote:
> As new_valid_dev always returns 1, so !new_valid_dev check is not
> needed, remove it.
>
> Signed-off-by: Yaowei Bai <[email protected]>

Thanks, applied.

- Ted

2015-10-30 01:38:55

by Yaowei Bai

Subject: Re: [PATCH 07/17] fs/ext4: remove unnecessary new_valid_dev check

On Thu, Oct 29, 2015 at 02:09:01PM -0400, Theodore Ts'o wrote:
> On Mon, Sep 28, 2015 at 09:50:37PM +0800, Yaowei Bai wrote:
> > As new_valid_dev always returns 1, so !new_valid_dev check is not
> > needed, remove it.
> >
> > Signed-off-by: Yaowei Bai <[email protected]>
>
> Thanks, applied.

Ted, this patch has been merged into andrew's mm tree.

>
> - Ted