2016-01-07 16:40:58

by Eric Whitney

Subject: [PATCH] e2fsck: fix problem report typo

Remove the stray left parenthesis. Observed while testing bigalloc_1k
filesystems with shared/298 on 32 bit ARM running 4.3 kernels.

Signed-off-by: Eric Whitney <[email protected]>
---
e2fsck/problem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/e2fsck/problem.c b/e2fsck/problem.c
index a7da94d..7bd660d 100644
--- a/e2fsck/problem.c
+++ b/e2fsck/problem.c
@@ -1255,7 +1255,7 @@ static struct e2fsck_problem problem_table[] = {

/* Inode extent tree could be narrower */
{ PR_1E_CAN_NARROW_EXTENT_TREE,
- N_("@i %i @x tree (at (level %b) could be narrower. "),
+ N_("@i %i @x tree (at level %b) could be narrower. "),
PROMPT_FIX, PR_NO_OK | PR_PREEN_NO | PR_PREEN_OK },

/* Pass 2 errors */
--
2.1.4

2016-01-07 18:00:20

by Eric Whitney

Subject: Re: [PATCH] e2fsck: fix problem report typo

* Eric Whitney <[email protected]>:
> Remove the stray left parenthesis. Observed while testing bigalloc_1k
> filesystems with shared/298 on 32 bit ARM running 4.3 kernels.
>
> Signed-off-by: Eric Whitney <[email protected]>
> ---
> e2fsck/problem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/e2fsck/problem.c b/e2fsck/problem.c
> index a7da94d..7bd660d 100644
> --- a/e2fsck/problem.c
> +++ b/e2fsck/problem.c
> @@ -1255,7 +1255,7 @@ static struct e2fsck_problem problem_table[] = {
>
> /* Inode extent tree could be narrower */
> { PR_1E_CAN_NARROW_EXTENT_TREE,
> - N_("@i %i @x tree (at (level %b) could be narrower. "),
> + N_("@i %i @x tree (at level %b) could be narrower. "),
> PROMPT_FIX, PR_NO_OK | PR_PREEN_NO | PR_PREEN_OK },
>
> /* Pass 2 errors */
> --
> 2.1.4
>

Oops. I neglected to modify the relevant test cases. Please ignore this
patch and I'll send something more complete shortly.

Thanks,
Eric