2016-01-20 20:19:40

by Eric Whitney

Subject: [PATCH] ext4: trim unused params from convert_initialized_extent()

The flags and newblock parameters are unused.

Signed-off-by: Eric Whitney <[email protected]>
---
fs/ext4/extents.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index b52fea3..0288b47 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3927,8 +3927,8 @@ get_reserved_cluster_alloc(struct inode *inode, ext4_lblk_t lblk_start,
static int
convert_initialized_extent(handle_t *handle, struct inode *inode,
struct ext4_map_blocks *map,
- struct ext4_ext_path **ppath, int flags,
- unsigned int allocated, ext4_fsblk_t newblock)
+ struct ext4_ext_path **ppath,
+ unsigned int allocated)
{
struct ext4_ext_path *path = *ppath;
struct ext4_extent *ex;
@@ -4347,7 +4347,7 @@ int ext4_ext_map_blocks(handle_t *handle, struct inode *inode,
(flags & EXT4_GET_BLOCKS_CONVERT_UNWRITTEN)) {
allocated = convert_initialized_extent(
handle, inode, map, &path,
- flags, allocated, newblock);
+ allocated);
goto out2;
} else if (!ext4_ext_is_unwritten(ex))
goto out;
--
2.1.4

2016-02-23 03:59:37

by Theodore Ts'o

Subject: Re: [PATCH] ext4: trim unused params from convert_initialized_extent()

On Wed, Jan 20, 2016 at 03:19:23PM -0500, Eric Whitney wrote:
> The flags and newblock parameters are unused.
>
> Signed-off-by: Eric Whitney <[email protected]>

Thanks, applied.

I've adjusted this patch to just remove the flags parameters (since
the newblock paramter was removed in another patch).

- Ted