I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]>
Signed-off-by: Baole Ni <[email protected]>
---
fs/jbd2/journal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index b31852f..9d78f55 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -54,7 +54,7 @@
ushort jbd2_journal_enable_debug __read_mostly;
EXPORT_SYMBOL(jbd2_journal_enable_debug);
-module_param_named(jbd2_debug, jbd2_journal_enable_debug, ushort, 0644);
+module_param_named(jbd2_debug, jbd2_journal_enable_debug, ushort, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(jbd2_debug, "Debugging level for jbd2");
#endif
--
2.9.2