2016-09-12 19:17:22

by Eric Biggers

Subject: [PATCH] ext4: fix memory leak when symlink decryption fails

This bug was introduced in v4.8-rc1.

Signed-off-by: Eric Biggers <[email protected]>
---
fs/ext4/symlink.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/symlink.c b/fs/ext4/symlink.c
index 4d83d9e..04a7850 100644
--- a/fs/ext4/symlink.c
+++ b/fs/ext4/symlink.c
@@ -65,13 +65,12 @@ static const char *ext4_encrypted_get_link(struct dentry *dentry,
res = fscrypt_fname_alloc_buffer(inode, cstr.len, &pstr);
if (res)
goto errout;
+ paddr = pstr.name;

res = fscrypt_fname_disk_to_usr(inode, 0, 0, &cstr, &pstr);
if (res < 0)
goto errout;

- paddr = pstr.name;

2016-09-15 17:16:57

by Theodore Ts'o

Subject: Re: [PATCH] ext4: fix memory leak when symlink decryption fails

On Mon, Sep 12, 2016 at 12:16:46PM -0700, Eric Biggers wrote:
> This bug was introduced in v4.8-rc1.
>
> Signed-off-by: Eric Biggers <[email protected]>

Thanks, applied.

- Ted