2016-09-20 16:16:18

by Eric Engestrom

Subject: [PATCH 1/2] ext4: remove unused variable

Signed-off-by: Eric Engestrom <[email protected]>
---
fs/ext4/dir.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c
index 67415e0..acd76f1 100644
--- a/fs/ext4/dir.c
+++ b/fs/ext4/dir.c
@@ -627,7 +627,7 @@ int ext4_check_all_de(struct inode *dir, struct buffer_head *bh, void *buf,
int buf_size)
{
struct ext4_dir_entry_2 *de;
- int nlen, rlen;
+ int rlen;
unsigned int offset = 0;
char *top;

@@ -637,7 +637,6 @@ int ext4_check_all_de(struct inode *dir, struct buffer_head *bh, void *buf,
if (ext4_check_dir_entry(dir, NULL, de, bh,
buf, buf_size, offset))
return -EFSCORRUPTED;
- nlen = EXT4_DIR_REC_LEN(de->name_len);
rlen = ext4_rec_len_from_disk(de->rec_len, buf_size);
de = (struct ext4_dir_entry_2 *)((char *)de + rlen);
offset += rlen;
--
Cheers,
Eric

2016-09-20 16:16:19

by Eric Engestrom

Subject: [PATCH 2/2] ext4: remove unused variable

Signed-off-by: Eric Engestrom <[email protected]>
---
fs/ext4/page-io.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
index a6132a7..b4cbee9 100644
--- a/fs/ext4/page-io.c
+++ b/fs/ext4/page-io.c
@@ -405,14 +405,12 @@ int ext4_bio_write_page(struct ext4_io_submit *io,
{
struct page *data_page = NULL;
struct inode *inode = page->mapping->host;
- unsigned block_start, blocksize;
+ unsigned block_start;
struct buffer_head *bh, *head;
int ret = 0;
int nr_submitted = 0;
int nr_to_submit = 0;

- blocksize = 1 << inode->i_blkbits;
-
BUG_ON(!PageLocked(page));
BUG_ON(PageWriteback(page));

--
Cheers,
Eric

2016-09-30 06:15:20

by Theodore Ts'o

Subject: Re: [PATCH 2/2] ext4: remove unused variable

On Tue, Sep 20, 2016 at 05:16:19PM +0100, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom <[email protected]>

Thanks, I've applied both of these cleanups.

- Ted