2017-06-30 03:53:13

by Wang Shilong

Subject: [PATCH 2/2] ext4, project: fix typo comments for quota credits reservation

Signed-off-by: Wang Shilong <[email protected]>
---
fs/ext4/ext4_jbd2.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/ext4_jbd2.h b/fs/ext4/ext4_jbd2.h
index f976111..6dd20c8 100644
--- a/fs/ext4/ext4_jbd2.h
+++ b/fs/ext4/ext4_jbd2.h
@@ -43,10 +43,10 @@
#define EXT4_XATTR_TRANS_BLOCKS 6U

/* Define the minimum size for a transaction which modifies data. This
- * needs to take into account the fact that we may end up modifying two
- * quota files too (one for the group, one for the user quota). The
- * superblock only gets updated once, of course, so don't bother
- * counting that again for the quota updates. */
+ * needs to take into account the fact that we may end up modifying three
+ * quota files too (one for the group, one for the user quota, one for the
+ * project). The superblock only gets updated once, of course, so don't
+ * bother counting that again for the quota updates. */

#define EXT4_DATA_TRANS_BLOCKS(sb) (EXT4_SINGLEDATA_TRANS_BLOCKS(sb) + \
EXT4_XATTR_TRANS_BLOCKS - 2 + \
--
2.9.3

2017-08-06 13:01:46

by Wang Shilong

Subject: Re: [PATCH 2/2] ext4, project: fix typo comments for quota credits reservation

Hi Ted,

how about this small typo fix. ^_^

On Fri, Jun 30, 2017 at 11:52 AM, Wang Shilong
<[email protected]> wrote:
> Signed-off-by: Wang Shilong <[email protected]>
> ---
> fs/ext4/ext4_jbd2.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ext4/ext4_jbd2.h b/fs/ext4/ext4_jbd2.h
> index f976111..6dd20c8 100644
> --- a/fs/ext4/ext4_jbd2.h
> +++ b/fs/ext4/ext4_jbd2.h
> @@ -43,10 +43,10 @@
> #define EXT4_XATTR_TRANS_BLOCKS 6U
>
> /* Define the minimum size for a transaction which modifies data. This
> - * needs to take into account the fact that we may end up modifying two
> - * quota files too (one for the group, one for the user quota). The
> - * superblock only gets updated once, of course, so don't bother
> - * counting that again for the quota updates. */
> + * needs to take into account the fact that we may end up modifying three
> + * quota files too (one for the group, one for the user quota, one for the
> + * project). The superblock only gets updated once, of course, so don't
> + * bother counting that again for the quota updates. */
>
> #define EXT4_DATA_TRANS_BLOCKS(sb) (EXT4_SINGLEDATA_TRANS_BLOCKS(sb) + \
> EXT4_XATTR_TRANS_BLOCKS - 2 + \
> --
> 2.9.3
>