2017-09-12 05:05:21

by Ross Zwisler

Subject: [PATCH v2 0/5] ext4: DAX data corruption fixes

This series prevents a pair of data corruptions with ext4 + DAX. The first
such corruption happens when combining the inline data feature with DAX,
and the second happens when combining data journaling with DAX.

Both can be reliably reproduced with the fstests that I have posted here:

https://patchwork.kernel.org/patch/9948377/
https://patchwork.kernel.org/patch/9948381/

My opinion is that the first three patches in this series should be applied
to the v4.14 RC series and backported to stable. The last two patches in
this series are just cleanup and can probably wait until v4.15.

Ross Zwisler (5):
ext4: prevent data corruption with inline data + DAX
ext4: prevent data corruption with journaling + DAX
ext4: add sanity check for encryption + DAX
ext4: add ext4_should_use_dax()
ext4: remove duplicate extended attributes defs

fs/ext4/ext4.h | 37 -------------------------------------
fs/ext4/inline.c | 10 ----------
fs/ext4/inode.c | 24 ++++++++++++++++--------
fs/ext4/ioctl.c | 16 +++++++++++++---
fs/ext4/super.c | 8 ++++++++
5 files changed, 37 insertions(+), 58 deletions(-)

--
2.9.5

2017-09-29 17:37:52

by Ross Zwisler

Subject: Re: [PATCH v2 0/5] ext4: DAX data corruption fixes

On Mon, Sep 11, 2017 at 11:05:21PM -0600, Ross Zwisler wrote:
> This series prevents a pair of data corruptions with ext4 + DAX. The first
> such corruption happens when combining the inline data feature with DAX,
> and the second happens when combining data journaling with DAX.
>
> Both can be reliably reproduced with the fstests that I have posted here:
>
> https://patchwork.kernel.org/patch/9948377/
> https://patchwork.kernel.org/patch/9948381/
>
> My opinion is that the first three patches in this series should be applied
> to the v4.14 RC series and backported to stable. The last two patches in
> this series are just cleanup and can probably wait until v4.15.
>
> Ross Zwisler (5):
> ext4: prevent data corruption with inline data + DAX
> ext4: prevent data corruption with journaling + DAX
> ext4: add sanity check for encryption + DAX
> ext4: add ext4_should_use_dax()
> ext4: remove duplicate extended attributes defs
>
> fs/ext4/ext4.h | 37 -------------------------------------
> fs/ext4/inline.c | 10 ----------
> fs/ext4/inode.c | 24 ++++++++++++++++--------
> fs/ext4/ioctl.c | 16 +++++++++++++---
> fs/ext4/super.c | 8 ++++++++
> 5 files changed, 37 insertions(+), 58 deletions(-)

Hey Ted,

I just wanted to ping this series, and see if at least the data corruption
fixes were headed for v4.14? I don't think these have been merged into any of
the ext4 branches yet.

Thanks,
- Ross