2018-09-25 00:18:59

by Gabriel Krisman Bertazi

Subject: [PATCH RESEND] ext4: Fix build error when DX_DEBUG is defined

Enabling DX_DEBUG triggers the build error below. info is an attribute
of the dxroot structure.

linux/fs/ext4/namei.c:2264:12: error: ‘info’
undeclared (first use in this function); did you mean ‘insl’?
info->indirect_levels));

Fixes: e08ac99fa2a2 ("ext4: add largedir feature")
Signed-off-by: Gabriel Krisman Bertazi <[email protected]>
Reviewed-by: Lukas Czerner <[email protected]>
---
fs/ext4/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 377d516c475f..67a38532032a 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2261,7 +2261,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,
dxroot->info.indirect_levels += 1;
dxtrace(printk(KERN_DEBUG
"Creating %d level index...\n",
- info->indirect_levels));
+ dxroot->info.indirect_levels));
err = ext4_handle_dirty_dx_node(handle, dir, frame->bh);
if (err)
goto journal_error;
--
2.19.0

2018-10-03 00:20:35

by Theodore Ts'o

Subject: Re: [PATCH RESEND] ext4: Fix build error when DX_DEBUG is defined

On Mon, Sep 24, 2018 at 02:15:24PM -0400, Gabriel Krisman Bertazi wrote:
> Enabling DX_DEBUG triggers the build error below. info is an attribute
> of the dxroot structure.
>
> linux/fs/ext4/namei.c:2264:12: error: ‘info’
> undeclared (first use in this function); did you mean ‘insl’?
> info->indirect_levels));
>
> Fixes: e08ac99fa2a2 ("ext4: add largedir feature")
> Signed-off-by: Gabriel Krisman Bertazi <[email protected]>
> Reviewed-by: Lukas Czerner <[email protected]>

Applied, thanks.

- Ted