2018-10-09 07:04:39

by Chengguang Xu

Subject: [PATCH] ext4: remove QUOTA flag setting in set_qf_name()

Mount flag QUOTA is the same as flag USRQUOTA in ext4, so should
not set flag QUOTA in set_qf_name().

Signed-off-by: Chengguang Xu <[email protected]>
---
fs/ext4/super.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 1145109968ef..9ed33e4860db 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1566,7 +1566,6 @@ static int set_qf_name(struct super_block *sb, int qtype, substring_t *args)
goto errout;
}
sbi->s_qf_names[qtype] = qname;
- set_opt(sb, QUOTA);
return 1;
errout:
kfree(qname);
--
2.17.1

2018-10-09 09:05:28

by Theodore Ts'o

Subject: Re: [PATCH] ext4: remove QUOTA flag setting in set_qf_name()

On Tue, Oct 09, 2018 at 07:50:13AM +0800, Chengguang Xu wrote:
> Mount flag QUOTA is the same as flag USRQUOTA in ext4, so should
> not set flag QUOTA in set_qf_name().
>
> Signed-off-by: Chengguang Xu <[email protected]>
> ---
> fs/ext4/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 1145109968ef..9ed33e4860db 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1566,7 +1566,6 @@ static int set_qf_name(struct super_block *sb, int qtype, substring_t *args)
> goto errout;
> }
> sbi->s_qf_names[qtype] = qname;
> - set_opt(sb, QUOTA);

No, sorry. This is still needed so that the usrjquota and the
grpjquota mount options will work correctly. And it's not like
set_qf_name() is a performance hot path.

- Ted