2018-12-26 16:08:26

by Theodore Ts'o

Subject: [PATCH] ext4/034: adjust commit which fixes the problem tested by ext4/034

Also add a requirment that fallocate and fiemap is supported.
(Fallocate isn't the case when we are emulating ext3, for example.)

Signed-off-by: Theodore Ts'o <[email protected]>
Cc: Liu Bo <[email protected]>
---
tests/ext4/034 | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/ext4/034 b/tests/ext4/034
index 5c34d0d9..f9e4bfaf 100755
--- a/tests/ext4/034
+++ b/tests/ext4/034
@@ -8,7 +8,7 @@
# "-o dioread_nolock,nodelalloc" is used.
#
# The bug was fixed by commit
-# "Ext4: fix ENOSPC when both quota and dioread_nolock are enabled"
+# "ext4: make sure enough credits are reserved for dioread_nolock writes"
#
seq=`basename $0`
seqres=$RESULT_DIR/$seq
@@ -41,6 +41,8 @@ _supported_os Linux
_require_scratch
_require_quota
_require_nobody
+_require_xfs_io_command "falloc"
+_require_xfs_io_command "fiemap"
_require_xfs_io_command "syncfs"

echo "Format and mount"
--
2.19.1

2018-12-29 13:54:24

by Theodore Ts'o

Subject: Re: [PATCH] ext4/034: adjust commit which fixes the problem tested by ext4/034

On Sat, Dec 29, 2018 at 01:08:46PM +0800, Eryu Guan wrote:
> On Wed, Dec 26, 2018 at 11:08:05AM -0500, Theodore Ts'o wrote:
> > Also add a requirment that fallocate and fiemap is supported.
> > (Fallocate isn't the case when we are emulating ext3, for example.)
> >
> > Signed-off-by: Theodore Ts'o <[email protected]>
> > Cc: Liu Bo <[email protected]>
>
> Patch looks good, but I assume you meant to send it to
> [email protected] not [email protected] :)

Oops, yes, that'd be correct.

- Ted

2018-12-29 05:08:55

by Eryu Guan

Subject: Re: [PATCH] ext4/034: adjust commit which fixes the problem tested by ext4/034

On Wed, Dec 26, 2018 at 11:08:05AM -0500, Theodore Ts'o wrote:
> Also add a requirment that fallocate and fiemap is supported.
> (Fallocate isn't the case when we are emulating ext3, for example.)
>
> Signed-off-by: Theodore Ts'o <[email protected]>
> Cc: Liu Bo <[email protected]>

Patch looks good, but I assume you meant to send it to
[email protected] not [email protected] :)

Thanks,
Eryu

> ---
> tests/ext4/034 | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/ext4/034 b/tests/ext4/034
> index 5c34d0d9..f9e4bfaf 100755
> --- a/tests/ext4/034
> +++ b/tests/ext4/034
> @@ -8,7 +8,7 @@
> # "-o dioread_nolock,nodelalloc" is used.
> #
> # The bug was fixed by commit
> -# "Ext4: fix ENOSPC when both quota and dioread_nolock are enabled"
> +# "ext4: make sure enough credits are reserved for dioread_nolock writes"
> #
> seq=`basename $0`
> seqres=$RESULT_DIR/$seq
> @@ -41,6 +41,8 @@ _supported_os Linux
> _require_scratch
> _require_quota
> _require_nobody
> +_require_xfs_io_command "falloc"
> +_require_xfs_io_command "fiemap"
> _require_xfs_io_command "syncfs"
>
> echo "Format and mount"
> --
> 2.19.1
>