2019-06-20 20:54:09

by Eric Biggers

Subject: [PATCH v5 04/16] fs: uapi: define verity bit for FS_IOC_GETFLAGS

From: Eric Biggers <[email protected]>

Add FS_VERITY_FL to the flags for FS_IOC_GETFLAGS, so that applications
can easily determine whether a file is a verity file at the same time as
they're checking other file flags. This flag will be gettable only;
FS_IOC_SETFLAGS won't allow setting it, since an ioctl must be used
instead to provide more parameters.

This flag matches the on-disk bit that was already allocated for ext4.

Reviewed-by: Theodore Ts'o <[email protected]>
Signed-off-by: Eric Biggers <[email protected]>
---
include/uapi/linux/fs.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
index 59c71fa8c553a3..df261b7e0587ed 100644
--- a/include/uapi/linux/fs.h
+++ b/include/uapi/linux/fs.h
@@ -306,6 +306,7 @@ struct fscrypt_key {
#define FS_TOPDIR_FL 0x00020000 /* Top of directory hierarchies*/
#define FS_HUGE_FILE_FL 0x00040000 /* Reserved for ext4 */
#define FS_EXTENT_FL 0x00080000 /* Extents */
+#define FS_VERITY_FL 0x00100000 /* Verity protected inode */
#define FS_EA_INODE_FL 0x00200000 /* Inode used for large EA */
#define FS_EOFBLOCKS_FL 0x00400000 /* Reserved for ext4 */
#define FS_NOCOW_FL 0x00800000 /* Do not cow file */
--
2.22.0.410.gd8fdbe21b5-goog

2019-06-22 22:12:53

by Jaegeuk Kim

Subject: Re: [PATCH v5 04/16] fs: uapi: define verity bit for FS_IOC_GETFLAGS

On 06/20, Eric Biggers wrote:
> From: Eric Biggers <[email protected]>
>
> Add FS_VERITY_FL to the flags for FS_IOC_GETFLAGS, so that applications
> can easily determine whether a file is a verity file at the same time as
> they're checking other file flags. This flag will be gettable only;
> FS_IOC_SETFLAGS won't allow setting it, since an ioctl must be used
> instead to provide more parameters.
>
> This flag matches the on-disk bit that was already allocated for ext4.
>
> Reviewed-by: Theodore Ts'o <[email protected]>

Reviewed-by: Jaegeuk Kim <[email protected]>

> Signed-off-by: Eric Biggers <[email protected]>
> ---
> include/uapi/linux/fs.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> index 59c71fa8c553a3..df261b7e0587ed 100644
> --- a/include/uapi/linux/fs.h
> +++ b/include/uapi/linux/fs.h
> @@ -306,6 +306,7 @@ struct fscrypt_key {
> #define FS_TOPDIR_FL 0x00020000 /* Top of directory hierarchies*/
> #define FS_HUGE_FILE_FL 0x00040000 /* Reserved for ext4 */
> #define FS_EXTENT_FL 0x00080000 /* Extents */
> +#define FS_VERITY_FL 0x00100000 /* Verity protected inode */
> #define FS_EA_INODE_FL 0x00200000 /* Inode used for large EA */
> #define FS_EOFBLOCKS_FL 0x00400000 /* Reserved for ext4 */
> #define FS_NOCOW_FL 0x00800000 /* Do not cow file */
> --
> 2.22.0.410.gd8fdbe21b5-goog